Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 26267003: Add the concept of a source set to GN. (Closed)

Created:
7 years, 2 months ago by brettw
Modified:
7 years, 2 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

Add the concept of a source set to GN. A source set acts like a static library in most cases, but doesn't actually make the library. The object files will be added to targets that depend on it. I changed the default component mode to be a "source set" rather than a shared library in non-component mode. This fixes the script target writer unit test on Windows. BUG= R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227596

Patch Set 1 #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+365 lines, -66 lines) Patch
M tools/gn/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/functions.h View 1 chunk +8 lines, -0 lines 0 comments Download
M tools/gn/functions.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/functions_target.cc View 3 chunks +64 lines, -11 lines 0 comments Download
M tools/gn/gn.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/ninja_binary_target_writer.h View 1 2 2 chunks +28 lines, -0 lines 0 comments Download
M tools/gn/ninja_binary_target_writer.cc View 5 chunks +129 lines, -42 lines 0 comments Download
A tools/gn/ninja_binary_target_writer_unittest.cc View 1 1 chunk +89 lines, -0 lines 0 comments Download
M tools/gn/ninja_helper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/ninja_script_target_writer_unittest.cc View 1 2 chunks +6 lines, -2 lines 0 comments Download
M tools/gn/ninja_target_writer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M tools/gn/output_file.h View 1 chunk +4 lines, -1 line 0 comments Download
M tools/gn/secondary/build/config/BUILDCONFIG.gn View 2 chunks +5 lines, -1 line 0 comments Download
M tools/gn/secondary/build/toolchain/nacl/BUILD.gn View 1 chunk +12 lines, -0 lines 0 comments Download
M tools/gn/secondary/chrome/BUILD.gn View 2 chunks +4 lines, -4 lines 0 comments Download
M tools/gn/target.h View 2 chunks +4 lines, -3 lines 0 comments Download
M tools/gn/target.cc View 1 chunk +2 lines, -1 line 0 comments Download
M tools/gn/target_generator.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
brettw
7 years, 2 months ago (2013-10-08 17:51:40 UTC) #1
scottmg
lgtm https://codereview.chromium.org/26267003/diff/3001/tools/gn/ninja_binary_target_writer.h File tools/gn/ninja_binary_target_writer.h (right): https://codereview.chromium.org/26267003/diff/3001/tools/gn/ninja_binary_target_writer.h#newcode44 tools/gn/ninja_binary_target_writer.h:44: // target, addint it to the appropriate vector. ...
7 years, 2 months ago (2013-10-08 18:42:03 UTC) #2
brettw
https://codereview.chromium.org/26267003/diff/3001/tools/gn/secondary/build/config/BUILDCONFIG.gn File tools/gn/secondary/build/config/BUILDCONFIG.gn (right): https://codereview.chromium.org/26267003/diff/3001/tools/gn/secondary/build/config/BUILDCONFIG.gn#newcode165 tools/gn/secondary/build/config/BUILDCONFIG.gn:165: component_mode = "source_set" We can continue this on the ...
7 years, 2 months ago (2013-10-08 20:17:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/26267003/3001
7 years, 2 months ago (2013-10-08 20:18:40 UTC) #4
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=29366
7 years, 2 months ago (2013-10-08 20:40:46 UTC) #5
brettw
7 years, 2 months ago (2013-10-08 21:30:48 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 manually as r227596 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698