Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1192)

Unified Diff: tools/gn/secondary/chrome/BUILD.gn

Issue 26267003: Add the concept of a source set to GN. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/secondary/build/toolchain/nacl/BUILD.gn ('k') | tools/gn/target.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/secondary/chrome/BUILD.gn
diff --git a/tools/gn/secondary/chrome/BUILD.gn b/tools/gn/secondary/chrome/BUILD.gn
index 133bf8214ce0e820c9003797066082bdf84810c0..4e6df28a6bc547cd692a6e426811aa786e136bc1 100644
--- a/tools/gn/secondary/chrome/BUILD.gn
+++ b/tools/gn/secondary/chrome/BUILD.gn
@@ -96,7 +96,7 @@ static_library("common") {
}
# TODO(brettw) move to browser/devtools/BUILD.gn
-static_library("debugger") {
+source_set("debugger") {
sources = [
"browser/devtools/adb/android_rsa.cc",
"browser/devtools/adb/android_rsa.h",
@@ -167,15 +167,15 @@ static_library("debugger") {
}
-static_library("plugin") {
+source_set("plugin") {
external = true
}
-static_library("renderer") {
+source_set("renderer") {
external = true
}
-static_library("utility") {
+source_set("utility") {
external = true
}
« no previous file with comments | « tools/gn/secondary/build/toolchain/nacl/BUILD.gn ('k') | tools/gn/target.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698