Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(780)

Unified Diff: tools/gn/target.h

Issue 26267003: Add the concept of a source set to GN. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/secondary/chrome/BUILD.gn ('k') | tools/gn/target.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/target.h
diff --git a/tools/gn/target.h b/tools/gn/target.h
index 92e8fe0191c64e4fcfda33ed067a7701e7421234..1bb51a6b388208686ddf3723747cb2f3126fe054 100644
--- a/tools/gn/target.h
+++ b/tools/gn/target.h
@@ -32,6 +32,7 @@ class Target : public Item {
EXECUTABLE,
SHARED_LIBRARY,
STATIC_LIBRARY,
+ SOURCE_SET,
COPY_FILES,
CUSTOM,
};
@@ -175,9 +176,9 @@ class Target : public Item {
bool external_;
- // Libraries from transitive deps. Libraries need to be linked only
- // with the end target (executable, shared library). These do not get
- // pushed beyond shared library boundaries.
+ // Static libraries and source sets from transitive deps. These things need
+ // to be linked only with the end target (executable, shared library). These
+ // do not get pushed beyond shared library boundaries.
std::set<const Target*> inherited_libraries_;
// These libs and dirs are inherited from statically linked deps and all
« no previous file with comments | « tools/gn/secondary/chrome/BUILD.gn ('k') | tools/gn/target.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698