Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2626623002: [turbofan] Graph building is independent of closure. (Closed)

Created:
3 years, 11 months ago by Michael Starzinger
Modified:
3 years, 11 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Graph building is independent of closure. This changes the BytecodeGraphBuilder interface to make the fact that graph construction is independent of a closure explicit. A valid graph can be constructed by providing only the pair of statically known values for SharedFunctionInfo and TypeFeedbackVector. This is in preparation of inlining based on the SharedFunctionInfo. R=jarin@chromium.org BUG=v8:2206 Review-Url: https://codereview.chromium.org/2626623002 Cr-Commit-Position: refs/heads/master@{#42224} Committed: https://chromium.googlesource.com/v8/v8/+/fc241b907732a5547d6302e367a7ec0da9e24909

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -23 lines) Patch
M src/compiler/bytecode-graph-builder.h View 2 chunks +4 lines, -5 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 2 chunks +12 lines, -11 lines 0 comments Download
M src/compiler/js-inlining.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +7 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (7 generated)
Michael Starzinger
3 years, 11 months ago (2017-01-10 12:31:12 UTC) #3
Jarin
lgtm
3 years, 11 months ago (2017-01-11 12:21:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626623002/1
3 years, 11 months ago (2017-01-11 12:37:08 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 13:05:59 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/fc241b907732a5547d6302e367a7ec0da9e...

Powered by Google App Engine
This is Rietveld 408576698