[turbofan] Enable inlining based on SharedFunctionInfo.

[turbofan] Enable inlining based on SharedFunctionInfo.

This adapts the inlining logic to allow for inlining based solely on a
statically known underlying SharedFunctionInfo instead of a concrete
closure of the call target.

In cases where the closure is known, its bound context is constant
promoted just as before. In the new cases where only the SFI for an
entire class of closures is known, we use the dynamic SSA-value of the
bound context.

R=bmeurer@chromium.org
BUG=v8:2206
Review-Url: https://codereview.chromium.org/2626783003
Cr-Commit-Position: refs/heads/master@{#42968}
Committed: https://chromium.googlesource.com/v8/v8/+/b628aba090e518c5de4147213803871e5eaf5f47

[Michael Starzinger, 2017-01-11 12:32:33]

Description was changed from

==========
[turbofan] Enable inlining based on SharedFunctionInfo.

This adapts the inlning logic to allow for inlining based solely on a
statically known underlying SharedFunctionInfo instead of a concrete
closure of the call target.

In cases where the closure is known, its bound context is constant
promoted just as before. In the new cases where only the class SFI for
an entire class of closures is known, we use the dynamic SSA-value of
the bound context.

R=
BUG=v8:2206
==========

to

==========
[turbofan] Enable inlining based on SharedFunctionInfo.

This adapts the inlining logic to allow for inlining based solely on a
statically known underlying SharedFunctionInfo instead of a concrete
closure of the call target.

In cases where the closure is known, its bound context is constant
promoted just as before. In the new cases where only the SFI for an
entire class of closures is known, we use the dynamic SSA-value of the
bound context.

R=
BUG=v8:2206
==========

[Michael Starzinger, 2017-01-11 12:33:17]

Description was changed from

==========
[turbofan] Enable inlining based on SharedFunctionInfo.

This adapts the inlining logic to allow for inlining based solely on a
statically known underlying SharedFunctionInfo instead of a concrete
closure of the call target.

In cases where the closure is known, its bound context is constant
promoted just as before. In the new cases where only the SFI for an
entire class of closures is known, we use the dynamic SSA-value of the
bound context.

R=
BUG=v8:2206
==========

to

==========
[turbofan] Enable inlining based on SharedFunctionInfo.

This adapts the inlining logic to allow for inlining based solely on a
statically known underlying SharedFunctionInfo instead of a concrete
closure of the call target.

In cases where the closure is known, its bound context is constant
promoted just as before. In the new cases where only the SFI for an
entire class of closures is known, we use the dynamic SSA-value of the
bound context.

R=bmeurer@chromium.org
BUG=v8:2206
==========

[Michael Starzinger, 2017-01-11 12:33:17]

mstarzinger@chromium.org changed reviewers:
+ bmeurer@chromium.org, mvstanton@chromium.org

[Michael Starzinger, 2017-01-11 14:18:40]

The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 14:18:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 14:36:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 14:36:41]

Dry run: Try jobs failed on following builders:
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/20626)
  v8_win_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng_triggered/bui...)

[Michael Starzinger, 2017-01-12 12:30:04]

The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 12:30:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 12:52:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 12:52:16]

Dry run: Try jobs failed on following builders:
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/20617)
  v8_win64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng_triggered/b...)

[Michael Starzinger, 2017-01-12 14:10:10]

PTAL. This is still failing due to dematerialized call targets (as discussed
offline). But I'd still like to get a first round of comments.

[Michael Starzinger, 2017-01-13 14:16:28]

The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 14:16:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Starzinger, 2017-01-13 14:42:08]

PTAL. This is now ready for prime time. It would be fine for me to wait until
after the branch cut, please advise on when to land.

[commit-bot: I haz the power, 2017-01-13 14:59:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 14:59:32]

Dry run: This issue passed the CQ dry run.

[Benedikt Meurer, 2017-01-13 18:18:29]

On 2017/01/13 14:42:08, Michael Starzinger wrote:
> PTAL. This is now ready for prime time. It would be fine for me to wait until
> after the branch cut, please advise on when to land.

I'd suggest to wait. Had a first look, and looks good to me. Will do a full
review next week.

[Michael Starzinger, 2017-02-06 12:17:42]

The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 12:17:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Starzinger, 2017-02-06 12:41:38]

Rebased. This should be ready for prime time now.

Michael: PTAL at the TFV use in JSInliner.
Benedikt: PTAL at everything.

[commit-bot: I haz the power, 2017-02-06 12:47:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 12:47:07]

Dry run: This issue passed the CQ dry run.

[Benedikt Meurer, 2017-02-06 13:04:49]

LGTM, thanks.

[mvstanton, 2017-02-06 13:51:38]

lgtm

[Michael Starzinger, 2017-02-06 13:52:52]

The CQ bit was checked by mstarzinger@chromium.org

[commit-bot: I haz the power, 2017-02-06 13:53:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 13:54:39]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1486389172807840,
"parent_rev": "ec922ef6c73f4917cc9f39e28204fbe36ce0ddb1", "commit_rev":
"b628aba090e518c5de4147213803871e5eaf5f47"}

[commit-bot: I haz the power, 2017-02-06 13:54:43]

Description was changed from

==========
[turbofan] Enable inlining based on SharedFunctionInfo.

This adapts the inlining logic to allow for inlining based solely on a
statically known underlying SharedFunctionInfo instead of a concrete
closure of the call target.

In cases where the closure is known, its bound context is constant
promoted just as before. In the new cases where only the SFI for an
entire class of closures is known, we use the dynamic SSA-value of the
bound context.

R=bmeurer@chromium.org
BUG=v8:2206
==========

to

==========
[turbofan] Enable inlining based on SharedFunctionInfo.

This adapts the inlining logic to allow for inlining based solely on a
statically known underlying SharedFunctionInfo instead of a concrete
closure of the call target.

In cases where the closure is known, its bound context is constant
promoted just as before. In the new cases where only the SFI for an
entire class of closures is known, we use the dynamic SSA-value of the
bound context.

R=bmeurer@chromium.org
BUG=v8:2206

Review-Url: https://codereview.chromium.org/2626783003
Cr-Commit-Position: refs/heads/master@{#42968}
Committed:
https://chromium.googlesource.com/v8/v8/+/b628aba090e518c5de4147213803871e5ea...
==========

[commit-bot: I haz the power, 2017-02-06 13:54:44]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/v8/v8/+/b628aba090e518c5de4147213803871e5ea...