third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js - Issue 2626553002: [Devtools][Code health] Changed NetworkRequest.url to proper getter/setter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js

Issue 2626553002: [Devtools][Code health] Changed NetworkRequest.url to proper getter/setter (Closed)

Patch Set: changes Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js ('k') | third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js b/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js

index a7e7edfee63dab1465057431b699525319819597..0937c3ef878adb27e61b22c3b300ae9387de8d87 100644

--- a/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js

+++ b/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js

@@ -176,7 +176,7 @@ Security.SecurityPanel = class extends UI.PanelWithSidebar {

* @param {!SDK.NetworkRequest} request

_processRequest(request) {

- var origin = Common.ParsedURL.extractOrigin(request.url);

+ var origin = Common.ParsedURL.extractOrigin(request.url());

if (!origin) {

// We don't handle resources like data: URIs. Most of them don't affect the lock icon.

@@ -348,7 +348,7 @@ Security.SecurityPanel = class extends UI.PanelWithSidebar {

this._mainView.refreshExplanations();

if (request) {

- var origin = Common.ParsedURL.extractOrigin(request.url);

+ var origin = Common.ParsedURL.extractOrigin(request.url());

this._sidebarTree.setMainOrigin(origin);

this._processRequest(request);

}