Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js

Issue 2626553002: [Devtools][Code health] Changed NetworkRequest.url to proper getter/setter (Closed)
Patch Set: changes Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js
index eae9251e9005566caaf2e9310077938664f63d03..9e8082c187ff320b55d658747270db853f512120 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js
@@ -677,13 +677,13 @@ SDK.ResourceTreeFrame = class {
* @param {!SDK.NetworkRequest} request
*/
_addRequest(request) {
- var resource = this._resourcesMap[request.url];
+ var resource = this._resourcesMap[request.url()];
if (resource && resource.request === request) {
// Already in the tree, we just got an extra update.
return;
}
resource = new SDK.Resource(
- this.target(), request, request.url, request.documentURL, request.frameId, request.loaderId,
+ this.target(), request, request.url(), request.documentURL, request.frameId, request.loaderId,
request.resourceType(), request.mimeType, null, null);
this._resourcesMap[resource.url] = resource;
this._model.dispatchEventToListeners(SDK.ResourceTreeModel.Events.ResourceAdded, resource);

Powered by Google App Engine
This is Rietveld 408576698