third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js - Issue 2626553002: [Devtools][Code health] Changed NetworkRequest.url to proper getter/setter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

Issue 2626553002: [Devtools][Code health] Changed NetworkRequest.url to proper getter/setter (Closed)

Patch Set: changes Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js b/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

index 9bd0b4e021b8edd6eb5d70d3eda5befffd00d35d..a78d5f35e6ae4439e109b3a71b79f4a7ee5129f8 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

@@ -903,7 +903,7 @@ Sources.SourcesPanel = class extends UI.Panel {

if (!(target instanceof SDK.NetworkRequest))

return;

var request = /** @type {!SDK.NetworkRequest} */ (target);

- var uiSourceCode = this._workspace.uiSourceCodeForURL(request.url);

+ var uiSourceCode = this._workspace.uiSourceCodeForURL(request.url());

if (!uiSourceCode)

return;

var openText = Common.UIString.capitalize('Open in Sources ^panel');

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js ('k') | no next file » | no next file with comments »