Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js

Issue 2626553002: [Devtools][Code health] Changed NetworkRequest.url to proper getter/setter (Closed)
Patch Set: changes Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js b/third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js
index b97c3afe22c0bbaf328b2aad425b121002c4b1e3..3d36def66e097e88e1c54dfc0d721987a4997734 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js
@@ -47,7 +47,7 @@ SDK.NetworkRequest = class extends SDK.SDKObject {
this._networkLog = /** @type {!SDK.NetworkLog} */ (SDK.NetworkLog.fromTarget(target));
this._networkManager = /** @type {!SDK.NetworkManager} */ (SDK.NetworkManager.fromTarget(target));
this._requestId = requestId;
- this.url = url;
+ this.setUrl(url);
this._documentURL = documentURL;
this._frameId = frameId;
this._loaderId = loaderId;
@@ -123,14 +123,14 @@ SDK.NetworkRequest = class extends SDK.SDKObject {
/**
* @return {string}
*/
- get url() {
+ url() {
return this._url;
}
/**
* @param {string} x
*/
- set url(x) {
+ setUrl(x) {
if (this._url === x)
return;
@@ -762,7 +762,7 @@ SDK.NetworkRequest = class extends SDK.SDKObject {
return this._queryString;
var queryString = null;
- var url = this.url;
+ var url = this.url();
var questionMarkPosition = url.indexOf('?');
if (questionMarkPosition !== -1) {
queryString = url.substring(questionMarkPosition + 1);
@@ -922,7 +922,7 @@ SDK.NetworkRequest = class extends SDK.SDKObject {
* @return {boolean}
*/
isHttpFamily() {
- return !!this.url.match(/^https?:/i);
+ return !!this.url().match(/^https?:/i);
}
/**
@@ -1045,7 +1045,7 @@ SDK.NetworkRequest = class extends SDK.SDKObject {
if (this.redirectSource) {
type = SDK.NetworkRequest.InitiatorType.Redirect;
- url = this.redirectSource.url;
+ url = this.redirectSource.url();
} else if (initiator) {
if (initiator.type === Protocol.Network.InitiatorType.Parser) {
type = SDK.NetworkRequest.InitiatorType.Parser;

Powered by Google App Engine
This is Rietveld 408576698