Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js

Issue 2626553002: [Devtools][Code health] Changed NetworkRequest.url to proper getter/setter (Closed)
Patch Set: changes Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js b/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js
index 510b9625ed727d0760327123050082c4eacafb86..dfddbede8ebcc0bf103e3d78338b1185ed1ef264 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js
@@ -205,8 +205,8 @@ SDK.NetworkDispatcher = class {
* @param {!Protocol.Network.Response=} response
*/
_updateNetworkRequestWithResponse(networkRequest, response) {
- if (response.url && networkRequest.url !== response.url)
- networkRequest.url = response.url;
+ if (response.url && networkRequest.url() !== response.url)
+ networkRequest.setUrl(response.url);
networkRequest.mimeType = response.mimeType;
networkRequest.statusCode = response.status;
networkRequest.statusText = response.statusText;
@@ -242,7 +242,7 @@ SDK.NetworkDispatcher = class {
consoleModel.target(), SDK.ConsoleMessage.MessageSource.Network, SDK.ConsoleMessage.MessageLevel.Log,
Common.UIString(
'Resource interpreted as %s but transferred with MIME type %s: "%s".',
- networkRequest.resourceType().title(), networkRequest.mimeType, networkRequest.url),
+ networkRequest.resourceType().title(), networkRequest.mimeType, networkRequest.url()),
SDK.ConsoleMessage.MessageType.Log, '', 0, 0, networkRequest.requestId()));
}
@@ -612,7 +612,7 @@ SDK.NetworkDispatcher = class {
*/
_startNetworkRequest(networkRequest) {
this._inflightRequestsById[networkRequest.requestId()] = networkRequest;
- this._inflightRequestsByURL[networkRequest.url] = networkRequest;
+ this._inflightRequestsByURL[networkRequest.url()] = networkRequest;
this._dispatchEventToListeners(SDK.NetworkManager.Events.RequestStarted, networkRequest);
}
@@ -635,7 +635,7 @@ SDK.NetworkDispatcher = class {
networkRequest.setTransferSize(encodedDataLength);
this._dispatchEventToListeners(SDK.NetworkManager.Events.RequestFinished, networkRequest);
delete this._inflightRequestsById[networkRequest.requestId()];
- delete this._inflightRequestsByURL[networkRequest.url];
+ delete this._inflightRequestsByURL[networkRequest.url()];
}
/**

Powered by Google App Engine
This is Rietveld 408576698