third_party/WebKit/Source/devtools/front_end/network/BlockedURLsPane.js - Issue 2626553002: [Devtools][Code health] Changed NetworkRequest.url to proper getter/setter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/BlockedURLsPane.js

Issue 2626553002: [Devtools][Code health] Changed NetworkRequest.url to proper getter/setter (Closed)

Patch Set: changes Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js ('k') | third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/network/BlockedURLsPane.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/BlockedURLsPane.js b/third_party/WebKit/Source/devtools/front_end/network/BlockedURLsPane.js

index a7a5716923ee5fbe9690a75e5fa097b0ca4f0b4f..1b7d1069d6fc5639dd45fece81d12dcdae619663 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/BlockedURLsPane.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/BlockedURLsPane.js

@@ -257,8 +257,8 @@ Network.BlockedURLsPane = class extends UI.VBox {

_onRequestFinished(event) {

var request = /** @type {!SDK.NetworkRequest} */ (event.data);

if (request.wasBlocked()) {

- var count = this._blockedCountForUrl.get(request.url) || 0;

- this._blockedCountForUrl.set(request.url, count + 1);

+ var count = this._blockedCountForUrl.get(request.url()) || 0;

+ this._blockedCountForUrl.set(request.url(), count + 1);

this._updateThrottler.schedule(this._update.bind(this));

}