Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Unified Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

Issue 2626553002: [Devtools][Code health] Changed NetworkRequest.url to proper getter/setter (Closed)
Patch Set: changes Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js b/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
index 884af2c0c76778351bf61a79af790ad9ff386d42..df9d67cce938b55e9164a1b6b871648fe8268537 100644
--- a/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
@@ -232,7 +232,7 @@ Console.ConsoleViewMessage = class {
consoleMessage.level === SDK.ConsoleMessage.MessageLevel.RevokedError) {
messageElement.createTextChild(consoleMessage.request.requestMethod + ' ');
messageElement.appendChild(Components.Linkifier.linkifyRevealable(
- consoleMessage.request, consoleMessage.request.url, consoleMessage.request.url));
+ consoleMessage.request, consoleMessage.request.url(), consoleMessage.request.url()));
if (consoleMessage.request.failed) {
messageElement.createTextChildren(' ', consoleMessage.request.localizedFailDescription);
} else {
@@ -272,7 +272,7 @@ Console.ConsoleViewMessage = class {
*/
function linkifyRequest(title) {
return Components.Linkifier.linkifyRevealable(
- /** @type {!SDK.NetworkRequest} */ (this.request), title, this.request.url);
+ /** @type {!SDK.NetworkRequest} */ (this.request), title, this.request.url());
}
}

Powered by Google App Engine
This is Rietveld 408576698