third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js - Issue 2626553002: [Devtools][Code health] Changed NetworkRequest.url to proper getter/setter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

Issue 2626553002: [Devtools][Code health] Changed NetworkRequest.url to proper getter/setter (Closed)

Patch Set: changes Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/network/BlockedURLsPane.js ('k') | third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

index 4ed55b93047a23d64f03ef1b7dbc9cf04e029a58..e91414fe94a549c4f427d98bf83b7776f3205379 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

@@ -659,7 +659,7 @@ Network.NetworkRequestNode = class extends Network.NetworkNode {

}

_openInNewTab() {

- InspectorFrontendHost.openInNewTab(this._request.url);

+ InspectorFrontendHost.openInNewTab(this._request.url());

}

/**

@@ -690,7 +690,7 @@ Network.NetworkRequestNode = class extends Network.NetworkNode {

cell.appendChild(iconElement);

cell.createTextChild(this._request.target().decorateLabel(this._request.name()));

this._appendSubtitle(cell, this._request.path());

- cell.title = this._request.url;

+ cell.title = this._request.url();

}

/**

@@ -768,7 +768,7 @@ Network.NetworkRequestNode = class extends Network.NetworkNode {

cell.title = initiator.url;

console.assert(request.redirectSource);

var redirectSource = /** @type {!SDK.NetworkRequest} */ (request.redirectSource);

- cell.appendChild(Components.Linkifier.linkifyURL(redirectSource.url));

+ cell.appendChild(Components.Linkifier.linkifyURL(redirectSource.url()));

this._appendSubtitle(cell, Common.UIString('Redirect'));

break;