Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2626543002: Handle ES3 Sampler types in getUniform in WebGL2RenderingContext (Closed)

Created:
3 years, 11 months ago by Zhenyao Mo
Modified:
3 years, 11 months ago
CC:
chromium-reviews, blink-reviews, haraken, Kai Ninomiya
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle ES3 Sampler types in getUniform in WebGL2RenderingContext BUG=679156 TEST=https://github.com/KhronosGroup/WebGL/pull/2248 R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2626543002 Cr-Commit-Position: refs/heads/master@{#442429} Committed: https://chromium.googlesource.com/chromium/src/+/c281383a4a0459271ea2a258c4e1a5262fa30f78

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 1 chunk +11 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (4 generated)
Zhenyao Mo
kbr, kainino: Please review.
3 years, 11 months ago (2017-01-09 22:32:17 UTC) #2
Ken Russell (switch to Gerrit)
Thanks for fixing this. A little discouraging that this omission wasn't caught by the existing ...
3 years, 11 months ago (2017-01-09 22:34:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626543002/1
3 years, 11 months ago (2017-01-09 22:35:43 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 00:56:37 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c281383a4a0459271ea2a258c4e1...

Powered by Google App Engine
This is Rietveld 408576698