Standardize Screen::GetCursorScreenPoint() on Env::last_mouse_location

Standardize Screen::GetCursorScreenPoint() on Env::last_mouse_location

For mus. Also, views::ScreenMus never gets a null delegate, so remove
code that allowed for null.

Env::last_mouse_location isn't always right for aura-mus, I filed 679402 to fix that.

BUG=660994
659155
TEST=none
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2626453002
Cr-Commit-Position: refs/heads/master@{#442304}
Committed: https://chromium.googlesource.com/chromium/src/+/48e288a65919ceb9be5ad527459f0544d2ef341d

[sky, 2017-01-09 18:12:52]

Description was changed from

==========
Standardize Screen::GetCursorScreenPoint() on Env::last_mouse_location

For mus. Also, views::ScreenMus never gets a null delegate, so remove
code that allowed for null.

BUG=660994 659155
TEST=none
R=erg@chromium.org
==========

to

==========
Standardize Screen::GetCursorScreenPoint() on Env::last_mouse_location

For mus. Also, views::ScreenMus never gets a null delegate, so remove
code that allowed for null.

Env::last_mouse_location isn't always right for aura-mus, I filed 679402 to fix
that.

BUG=660994 659155
TEST=none
R=erg@chromium.org
==========

[sky, 2017-01-09 18:13:19]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 18:13:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Elliot Glaysher, 2017-01-09 18:16:42]

https://codereview.chromium.org/2626453002/diff/2/ui/views/mus/mus_client.cc
File ui/views/mus/mus_client.cc (left):

https://codereview.chromium.org/2626453002/diff/2/ui/views/mus/mus_client.cc#...
ui/views/mus/mus_client.cc:266: return
window_tree_client_->GetCursorScreenPoint();
Remove the window tree client code too?

(Or are you ignoring this since you plan on just deleting
services/ui/public/cpp/ soon?)

[sky, 2017-01-09 18:20:23]

https://codereview.chromium.org/2626453002/diff/2/ui/views/mus/mus_client.cc
File ui/views/mus/mus_client.cc (left):

https://codereview.chromium.org/2626453002/diff/2/ui/views/mus/mus_client.cc#...
ui/views/mus/mus_client.cc:266: return
window_tree_client_->GetCursorScreenPoint();
On 2017/01/09 18:16:42, Elliot Glaysher wrote:
> Remove the window tree client code too?
> 
> (Or are you ignoring this since you plan on just deleting
> services/ui/public/cpp/ soon?)

We still need both. As clients don't see all events they need to use
WindowTreeClient::GetCursorScreenPoint() outside of event dispatching. In other
words Env::last_mouse_location() needs to call
WindowTreeClient::GetCursorScreenPoint() if called outside of event dispatching.
I filed 679402 for this.

[Elliot Glaysher, 2017-01-09 18:28:00]

lgtm

[sky, 2017-01-09 18:39:42]

The CQ bit was unchecked by sky@chromium.org

[sky, 2017-01-09 18:39:45]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2017-01-09 18:39:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 19:13:52]

CQ is committing da patch.

Bot data: {"patchset_id": 2, "attempt_start_ts": 1483987185397510, "parent_rev":
"25bc7c50fe2201b5d542fa2ec99f23b2ef979a19", "commit_rev":
"48e288a65919ceb9be5ad527459f0544d2ef341d"}

[commit-bot: I haz the power, 2017-01-09 19:14:20]

Description was changed from

==========
Standardize Screen::GetCursorScreenPoint() on Env::last_mouse_location

For mus. Also, views::ScreenMus never gets a null delegate, so remove
code that allowed for null.

Env::last_mouse_location isn't always right for aura-mus, I filed 679402 to fix
that.

BUG=660994 659155
TEST=none
R=erg@chromium.org
==========

to

==========
Standardize Screen::GetCursorScreenPoint() on Env::last_mouse_location

For mus. Also, views::ScreenMus never gets a null delegate, so remove
code that allowed for null.

Env::last_mouse_location isn't always right for aura-mus, I filed 679402 to fix
that.

BUG=660994 659155
TEST=none
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2626453002
Cr-Commit-Position: refs/heads/master@{#442304}
Committed:
https://chromium.googlesource.com/chromium/src/+/48e288a65919ceb9be5ad527459f...
==========

[commit-bot: I haz the power, 2017-01-09 19:14:21]

Committed patchset #2 (id:2) as
https://chromium.googlesource.com/chromium/src/+/48e288a65919ceb9be5ad527459f...