Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Unified Diff: ui/views/mus/screen_mus.cc

Issue 2626453002: Standardize Screen::GetCursorScreenPoint() on Env::last_mouse_location (Closed)
Patch Set: explicit Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/mus/screen_mus.cc
diff --git a/ui/views/mus/screen_mus.cc b/ui/views/mus/screen_mus.cc
index 023b29c13a76d46d3e5d630d71c06bd040ecb0f8..fc40955c4e2dd9e744f2dc2d898353ce011b8ba3 100644
--- a/ui/views/mus/screen_mus.cc
+++ b/ui/views/mus/screen_mus.cc
@@ -11,6 +11,7 @@
#include "services/service_manager/public/cpp/connection.h"
#include "services/service_manager/public/cpp/connector.h"
#include "services/ui/public/interfaces/constants.mojom.h"
+#include "ui/aura/env.h"
#include "ui/aura/window.h"
#include "ui/views/mus/screen_mus_delegate.h"
#include "ui/views/mus/window_manager_frame_values.h"
@@ -38,6 +39,7 @@ using Type = display::DisplayList::Type;
ScreenMus::ScreenMus(ScreenMusDelegate* delegate)
: delegate_(delegate), display_manager_observer_binding_(this) {
+ DCHECK(delegate);
display::Screen::SetScreenInstance(this);
}
@@ -71,14 +73,7 @@ void ScreenMus::Init(service_manager::Connector* connector) {
}
gfx::Point ScreenMus::GetCursorScreenPoint() {
- if (!delegate_) {
- // TODO(erg): If we need the cursor point in the window manager, we'll need
- // to make |delegate_| required. It only recently changed to be optional.
- NOTIMPLEMENTED();
- return gfx::Point();
- }
-
- return delegate_->GetCursorScreenPoint();
+ return aura::Env::GetInstance()->last_mouse_location();
}
bool ScreenMus::IsWindowUnderCursor(gfx::NativeWindow window) {
@@ -131,8 +126,7 @@ void ScreenMus::OnDisplaysChanged(
ws_displays[i]
->frame_decoration_values.To<WindowManagerFrameValues>();
WindowManagerFrameValues::SetInstance(frame_values);
- if (delegate_)
- delegate_->OnWindowManagerFrameValuesChanged();
+ delegate_->OnWindowManagerFrameValuesChanged();
}
}
}

Powered by Google App Engine
This is Rietveld 408576698