Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(927)

Issue 2178483002: Clang update.py: ToT version is now 4.0.0 (Closed)

Created:
4 years, 5 months ago by hans
Modified:
4 years, 4 months ago
Reviewers:
krasin1, Nico, krasin
CC:
chromium-reviews, eugenis+clang_chromium.org, vmpstr+watch_chromium.org, yunlian, glider+clang_chromium.org, Nico, ukai+watch_chromium.org, Reid Kleckner, dmikurube+clang_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clang update.py: ToT version is now 4.0.0 BUG=none Committed: https://crrev.com/17121a75ffda6c5882502d1cb495afe8d4058a29 Cr-Commit-Position: refs/heads/master@{#407220}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M tools/clang/scripts/update.py View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
hans
Please take a look. (This is the CL from last time: https://codereview.chromium.org/1587683002)
4 years, 5 months ago (2016-07-22 15:08:59 UTC) #2
krasin
lgtm
4 years, 5 months ago (2016-07-22 17:14:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2178483002/1
4 years, 5 months ago (2016-07-22 17:16:38 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 18:53:45 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/17121a75ffda6c5882502d1cb495afe8d4058a29 Cr-Commit-Position: refs/heads/master@{#407220}
4 years, 5 months ago (2016-07-22 18:55:22 UTC) #9
Nico
what about https://cs.chromium.org/chromium/src/build/toolchain/toolchain.gni?rcl=0&l=27 ?
4 years, 4 months ago (2016-07-29 18:28:43 UTC) #11
Nico
There's also https://cs.chromium.org/search/?q=3%5C.9%5C.0+-file:third_party/llvm+-file:sqlite+-file:luci+file:json+file:recipe&sq=package:chromium&type=cs , but I think I told someone not to hardcode this in ...
4 years, 4 months ago (2016-07-29 18:30:35 UTC) #12
hans
4 years, 4 months ago (2016-08-01 21:32:31 UTC) #13
Message was sent while issue was closed.
On 2016/07/29 18:28:43, Nico wrote:
> what about
> https://cs.chromium.org/chromium/src/build/toolchain/toolchain.gni?rcl=0&l=27
?

Sorry for the delay
https://codereview.chromium.org/2201983002/

Powered by Google App Engine
This is Rietveld 408576698