Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(793)

Issue 2626283003: media: Simplify audio test names (Closed)

Created:
3 years, 11 months ago by xhwang
Modified:
3 years, 11 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Simplify audio test names Examples: AudioRendererMixerBehavioralTest/AudioRendererMixerBehavioralTest.OnRenderError -> AudioRendererMixerBehavioralTest.OnRenderError MediaCodecAudioDecoderTest/AudioDecoderTest.Reset/0 -> MediaCodec/AudioDecoderTest.Reset/0 Review-Url: https://codereview.chromium.org/2626283003 Cr-Commit-Position: refs/heads/master@{#443760} Committed: https://chromium.googlesource.com/chromium/src/+/363c1602576bbf0c2241d439ae6a87ee07007e2b

Patch Set 1 #

Total comments: 3

Patch Set 2 : media: Simplify audio test names #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -13 lines) Patch
M media/base/audio_renderer_mixer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/audio_decoder_unittest.cc View 1 3 chunks +2 lines, -12 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
xhwang
Some cleanup coming out of my other change. PTAL https://codereview.chromium.org/2626283003/diff/1/media/filters/audio_decoder_unittest.cc File media/filters/audio_decoder_unittest.cc (right): https://codereview.chromium.org/2626283003/diff/1/media/filters/audio_decoder_unittest.cc#newcode584 media/filters/audio_decoder_unittest.cc:584: ...
3 years, 11 months ago (2017-01-13 17:32:51 UTC) #6
DaleCurtis
lgtm https://codereview.chromium.org/2626283003/diff/1/media/filters/audio_decoder_unittest.cc File media/filters/audio_decoder_unittest.cc (right): https://codereview.chromium.org/2626283003/diff/1/media/filters/audio_decoder_unittest.cc#newcode584 media/filters/audio_decoder_unittest.cc:584: FFmpegAudioDecoderBehavioralTest, On 2017/01/13 at 17:32:51, xhwang wrote: > ...
3 years, 11 months ago (2017-01-14 00:26:20 UTC) #7
xhwang
https://codereview.chromium.org/2626283003/diff/1/media/filters/audio_decoder_unittest.cc File media/filters/audio_decoder_unittest.cc (right): https://codereview.chromium.org/2626283003/diff/1/media/filters/audio_decoder_unittest.cc#newcode584 media/filters/audio_decoder_unittest.cc:584: FFmpegAudioDecoderBehavioralTest, On 2017/01/14 00:26:20, DaleCurtis wrote: > On 2017/01/13 ...
3 years, 11 months ago (2017-01-14 00:28:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2626283003/20001
3 years, 11 months ago (2017-01-14 00:42:32 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-14 01:37:34 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/363c1602576bbf0c2241d439ae6a...

Powered by Google App Engine
This is Rietveld 408576698