Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: media/filters/audio_decoder_unittest.cc

Issue 2626283003: media: Simplify audio test names (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « media/base/audio_renderer_mixer_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 #include <stdint.h> 6 #include <stdint.h>
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 465 matching lines...) Expand 10 before | Expand all | Expand 10 after
476 {MEDIA_CODEC, kCodecOpus, "bear-opus.ogg", kBearOpusExpectations, 24, 48000, 476 {MEDIA_CODEC, kCodecOpus, "bear-opus.ogg", kBearOpusExpectations, 24, 48000,
477 CHANNEL_LAYOUT_STEREO}, 477 CHANNEL_LAYOUT_STEREO},
478 #if defined(USE_PROPRIETARY_CODECS) 478 #if defined(USE_PROPRIETARY_CODECS)
479 {MEDIA_CODEC, kCodecAAC, "sfx.adts", kSfxAdtsMcExpectations, 0, 44100, 479 {MEDIA_CODEC, kCodecAAC, "sfx.adts", kSfxAdtsMcExpectations, 0, 44100,
480 CHANNEL_LAYOUT_MONO}, 480 CHANNEL_LAYOUT_MONO},
481 {MEDIA_CODEC, kCodecAAC, "bear-audio-implicit-he-aac-v2.aac", 481 {MEDIA_CODEC, kCodecAAC, "bear-audio-implicit-he-aac-v2.aac",
482 kHeAacMcExpectations, 0, 24000, CHANNEL_LAYOUT_MONO}, 482 kHeAacMcExpectations, 0, 24000, CHANNEL_LAYOUT_MONO},
483 #endif 483 #endif
484 }; 484 };
485 485
486 INSTANTIATE_TEST_CASE_P(MediaCodecAudioDecoderTest, 486 INSTANTIATE_TEST_CASE_P(MediaCodec,
487 AudioDecoderTest, 487 AudioDecoderTest,
488 testing::ValuesIn(kMediaCodecTests)); 488 testing::ValuesIn(kMediaCodecTests));
489 #endif // defined(OS_ANDROID) 489 #endif // defined(OS_ANDROID)
490 490
491 #if defined(USE_PROPRIETARY_CODECS) 491 #if defined(USE_PROPRIETARY_CODECS)
492 const DecodedBufferExpectations kSfxMp3Expectations[] = { 492 const DecodedBufferExpectations kSfxMp3Expectations[] = {
493 {0, 1065, "2.81,3.99,4.53,4.10,3.08,2.46,"}, 493 {0, 1065, "2.81,3.99,4.53,4.10,3.08,2.46,"},
494 {1065, 26122, "-3.81,-4.14,-3.90,-3.36,-3.03,-3.23,"}, 494 {1065, 26122, "-3.81,-4.14,-3.90,-3.36,-3.03,-3.23,"},
495 {27188, 26122, "4.24,3.95,4.22,4.78,5.13,4.93,"}, 495 {27188, 26122, "4.24,3.95,4.22,4.78,5.13,4.93,"},
496 }; 496 };
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
569 CHANNEL_LAYOUT_MONO}, 569 CHANNEL_LAYOUT_MONO},
570 {FFMPEG, kCodecOpus, "bear-opus.ogg", kBearOpusExpectations, 24, 48000, 570 {FFMPEG, kCodecOpus, "bear-opus.ogg", kBearOpusExpectations, 24, 48000,
571 CHANNEL_LAYOUT_STEREO}, 571 CHANNEL_LAYOUT_STEREO},
572 }; 572 };
573 573
574 // Dummy data for behavioral tests. 574 // Dummy data for behavioral tests.
575 const DecoderTestData kFFmpegBehavioralTest[] = { 575 const DecoderTestData kFFmpegBehavioralTest[] = {
576 {FFMPEG, kUnknownAudioCodec, "", NULL, 0, 0, CHANNEL_LAYOUT_NONE}, 576 {FFMPEG, kUnknownAudioCodec, "", NULL, 0, 0, CHANNEL_LAYOUT_NONE},
577 }; 577 };
578 578
579 INSTANTIATE_TEST_CASE_P(FFmpegAudioDecoderTest, 579 INSTANTIATE_TEST_CASE_P(FFmpeg,
580 AudioDecoderTest, 580 AudioDecoderTest,
581 testing::ValuesIn(kFFmpegTests)); 581 testing::ValuesIn(kFFmpegTests));
582 INSTANTIATE_TEST_CASE_P(FFmpegAudioDecoderBehavioralTest, 582
583 INSTANTIATE_TEST_CASE_P(/* no prefix */,
583 FFmpegAudioDecoderBehavioralTest, 584 FFmpegAudioDecoderBehavioralTest,
xhwang 2017/01/13 17:32:51 It seems this test is empty. Do we still need it?
DaleCurtis 2017/01/14 00:26:20 Don't think so? See l.575.
xhwang 2017/01/14 00:28:05 k, I'll just remove it.
584 testing::ValuesIn(kFFmpegBehavioralTest)); 585 testing::ValuesIn(kFFmpegBehavioralTest));
585 586
586 } // namespace media 587 } // namespace media
OLDNEW
« no previous file with comments | « media/base/audio_renderer_mixer_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698