Add more criteria to wait until keyboard appears.

Add more criteria to wait until keyboard appears.

The testBrowsingPostEntryWithKeyboard test is flaky on device, with the
failure that the Go button on the keyboard is not interactable when tap
is performed. This implies that the tap is reached before the keyboard
is fully interactable, so this CL adds a requirement that the button is
interactable to the wait criteria.

BUG=670380
Review-Url: https://codereview.chromium.org/2626143002
Cr-Commit-Position: refs/heads/master@{#443038}
Committed: https://chromium.googlesource.com/chromium/src/+/e0ba8c7a2c6f419d37532d31c79d2eaf62723ce8

[gchatz, 2017-01-11 21:59:16]

Description was changed from

==========
Add more criteria to wait until keyboard appears.

The testBrowsingPostEntryWithKeyboard test is flaky on device, with
failure that the Go button on the keyboard is not interactable when tap
is performed. This implies that the tap is reached before the keyboard
is fully interactable, so this CL adds the interactable requirement
to the wait until criteria.

BUG=670380
==========

to

==========
Add more criteria to wait until keyboard appears.

The testBrowsingPostEntryWithKeyboard test is flaky on device, with the
failure that the Go button on the keyboard is not interactable when tap
is performed. This implies that the tap is reached before the keyboard
is fully interactable, so this CL adds a requirement that the button is
interactable to the wait criteria.

BUG=670380
==========

[gchatz, 2017-01-11 22:13:03]

gchatz@chromium.org changed reviewers:
+ eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2017-01-11 22:15:12]

lgtm

https://codereview.chromium.org/2626143002/diff/20001/ios/chrome/browser/web/...
File ios/chrome/browser/web/browsing_egtest.mm (right):

https://codereview.chromium.org/2626143002/diff/20001/ios/chrome/browser/web/...
ios/chrome/browser/web/browsing_egtest.mm:624: id<GREYMatcher> keyboardGoButton
= grey_allOf(
s/keyboardGoButton/keyboardGoButtonMatcher

https://codereview.chromium.org/2626143002/diff/20001/ios/chrome/browser/web/...
ios/chrome/browser/web/browsing_egtest.mm:624: id<GREYMatcher> keyboardGoButton
= grey_allOf(
Should this be a function instead of local variable?

[gchatz, 2017-01-11 22:28:41]

https://codereview.chromium.org/2626143002/diff/20001/ios/chrome/browser/web/...
File ios/chrome/browser/web/browsing_egtest.mm (right):

https://codereview.chromium.org/2626143002/diff/20001/ios/chrome/browser/web/...
ios/chrome/browser/web/browsing_egtest.mm:624: id<GREYMatcher> keyboardGoButton
= grey_allOf(
On 2017/01/11 22:15:12, Eugene But wrote:
> s/keyboardGoButton/keyboardGoButtonMatcher

Done with method.

https://codereview.chromium.org/2626143002/diff/20001/ios/chrome/browser/web/...
ios/chrome/browser/web/browsing_egtest.mm:624: id<GREYMatcher> keyboardGoButton
= grey_allOf(
On 2017/01/11 22:15:12, Eugene But wrote:
> Should this be a function instead of local variable?

I moved it to a method in case other places that interact with a keyboard in
this file need it.

[gchatz, 2017-01-11 22:28:54]

The CQ bit was checked by gchatz@chromium.org

[gchatz, 2017-01-11 22:28:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2626143002/#ps40001
(title: "abstract matcher to method")

[commit-bot: I haz the power, 2017-01-11 22:30:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 22:58:45]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484173734506450,
"parent_rev": "55f0eaf2e3f710faafcae8cf32546729adce93b6", "commit_rev":
"e0ba8c7a2c6f419d37532d31c79d2eaf62723ce8"}

[commit-bot: I haz the power, 2017-01-11 22:59:15]

Description was changed from

==========
Add more criteria to wait until keyboard appears.

The testBrowsingPostEntryWithKeyboard test is flaky on device, with the
failure that the Go button on the keyboard is not interactable when tap
is performed. This implies that the tap is reached before the keyboard
is fully interactable, so this CL adds a requirement that the button is
interactable to the wait criteria.

BUG=670380
==========

to

==========
Add more criteria to wait until keyboard appears.

The testBrowsingPostEntryWithKeyboard test is flaky on device, with the
failure that the Go button on the keyboard is not interactable when tap
is performed. This implies that the tap is reached before the keyboard
is fully interactable, so this CL adds a requirement that the button is
interactable to the wait criteria.

BUG=670380

Review-Url: https://codereview.chromium.org/2626143002
Cr-Commit-Position: refs/heads/master@{#443038}
Committed:
https://chromium.googlesource.com/chromium/src/+/e0ba8c7a2c6f419d37532d31c79d...
==========

[commit-bot: I haz the power, 2017-01-11 22:59:16]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e0ba8c7a2c6f419d37532d31c79d...