Add more criteria to wait until keyboard appears.

ios/chrome/browser/web/browsing_egtest.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <XCTest/XCTest.h>
 #include <map>
 #include <memory>
 #include <string>
 
 #include "base/ios/ios_util.h"
@@ skipping 603 matching lines @@
   // keyboard from a web view.
   [[GREYConfiguration sharedInstance]
           setValue:@NO
       forConfigKey:kGREYConfigKeySynchronizationEnabled];
 
   // Wait until the keyboard shows up before tapping.
   GREYCondition* condition = [GREYCondition
       conditionWithName:@"Wait for the keyboard to show up."
                   block:^BOOL {
                     NSError* error = nil;
-                    [[EarlGrey
-                        selectElementWithMatcher:grey_accessibilityID(@"Go")]
+                    id<GREYMatcher> keyboardGoButton = grey_allOf(

[Eugene But (OOO till 7-30), 2017/01/11 22:15:12]

Should this be a function instead of local variable?

[Eugene But (OOO till 7-30), 2017/01/11 22:15:12]

s/keyboardGoButton/keyboardGoButtonMatcher

[gchatz, 2017/01/11 22:28:41]

I moved it to a method in case other places that interact with a keyboard in
this file need it. 

[gchatz, 2017/01/11 22:28:41]

Done with method. 

+                        grey_accessibilityID(@"Go"), grey_interactable(), nil);
+                    [[EarlGrey selectElementWithMatcher:keyboardGoButton]
                         assertWithMatcher:grey_notNil()
                                     error:&error];
                     return (error == nil);
                   }];
   GREYAssert([condition waitWithTimeout:10],
              @"No keyboard with 'Go' button showed up.");
 
   [[EarlGrey selectElementWithMatcher:grey_accessibilityID(@"Go")]
       performAction:grey_tap()];
 
   // Reenable synchronization now that the keyboard has been closed.
   [[GREYConfiguration sharedInstance]
           setValue:@YES
       forConfigKey:kGREYConfigKeySynchronizationEnabled];
 
   // Verify that the browser navigates to the expected URL.
   [[EarlGrey selectElementWithMatcher:omniboxText(destinationURL.GetContent())]
       assertWithMatcher:grey_notNil()];
 
   // Go back and verify that the browser navigates to the original URL.
   [self goBack];
   [[EarlGrey selectElementWithMatcher:omniboxText(URL.GetContent())]
       assertWithMatcher:grey_notNil()];
 }
 
 @end