[Clean] Add unittest target and BrowserCoordinator tests.

[Clean] Add unittest target and BrowserCoordinator tests.

This CL adds an ios_clean_chrome_unittests target and tests for the
public and internal APIs of BrowserCoordinator.

BUG=

Review-Url: https://codereview.chromium.org/2626033002
Cr-Commit-Position: refs/heads/master@{#443339}
Committed: https://chromium.googlesource.com/chromium/src/+/6265874469d83f83efc4d6b370d391e8eb29bccb

[marq (ping after 24h), 2017-01-11 13:09:19]

Cleanup

[marq (ping after 24h), 2017-01-11 13:11:42]

Cleanup

[marq (ping after 24h), 2017-01-11 13:13:25]

marq@chromium.org changed reviewers:
+ lpromero@chromium.org, sdefresne@chromium.org

[marq (ping after 24h), 2017-01-11 13:13:25]

https://codereview.chromium.org/2626033002/diff/40001/ios/clean/chrome/browse...
File ios/clean/chrome/browser/BUILD.gn (right):

https://codereview.chromium.org/2626033002/diff/40001/ios/clean/chrome/browse...
ios/clean/chrome/browser/BUILD.gn:17: "//ios/chrome/app:tests_fake_hook",
These additions are required to link ChromeBrowserState :-(.

[lpromero, 2017-01-11 13:29:25]

lgtm

https://codereview.chromium.org/2626033002/diff/40001/ios/clean/chrome/browse...
File ios/clean/chrome/browser/browser_coordinator.mm (right):

https://codereview.chromium.org/2626033002/diff/40001/ios/clean/chrome/browse...
ios/clean/chrome/browser/browser_coordinator.mm:114: // By default, coordinators
with no other children can add an overlay.
All this logic should be documented in a header or design doc?

https://codereview.chromium.org/2626033002/diff/40001/ios/clean/chrome/browse...
File ios/clean/chrome/browser/browser_coordinator_unittest.mm (right):

https://codereview.chromium.org/2626033002/diff/40001/ios/clean/chrome/browse...
ios/clean/chrome/browser/browser_coordinator_unittest.mm:55: @autoreleasepool {
Why autoreleasepool and not just braces?

[marq (ping after 24h), 2017-01-11 14:06:06]

Review feedback.

[marq (ping after 24h), 2017-01-11 14:06:25]

Thanks for the review!

https://codereview.chromium.org/2626033002/diff/40001/ios/clean/chrome/browse...
File ios/clean/chrome/browser/browser_coordinator.mm (right):

https://codereview.chromium.org/2626033002/diff/40001/ios/clean/chrome/browse...
ios/clean/chrome/browser/browser_coordinator.mm:114: // By default, coordinators
with no other children can add an overlay.
On 2017/01/11 13:29:25, lpromero wrote:
> All this logic should be documented in a header or design doc? 

I'll update the header.

https://codereview.chromium.org/2626033002/diff/40001/ios/clean/chrome/browse...
File ios/clean/chrome/browser/browser_coordinator_unittest.mm (right):

https://codereview.chromium.org/2626033002/diff/40001/ios/clean/chrome/browse...
ios/clean/chrome/browser/browser_coordinator_unittest.mm:55: @autoreleasepool {
On 2017/01/11 13:29:25, lpromero wrote:
> Why autoreleasepool and not just braces?

Done.

[marq (ping after 24h), 2017-01-11 14:37:20]

The CQ bit was checked by marq@chromium.org

[marq (ping after 24h), 2017-01-11 14:37:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
lpromero@chromium.org
Link to the patchset: https://codereview.chromium.org/2626033002/#ps60001
(title: "Review feedback.")

[marq (ping after 24h), 2017-01-11 14:37:25]

The CQ bit was unchecked by marq@chromium.org

[marq (ping after 24h), 2017-01-12 19:05:41]

The CQ bit was checked by marq@chromium.org

[commit-bot: I haz the power, 2017-01-12 19:06:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 20:20:36]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484247941114600,
"parent_rev": "8f3a9a68b2dcdd2c54cf49a41ad34729ab576702", "commit_rev":
"6265874469d83f83efc4d6b370d391e8eb29bccb"}

[commit-bot: I haz the power, 2017-01-12 20:21:08]

Description was changed from

==========
[Clean] Add unittest target and BrowserCoordinator tests.

This CL adds an ios_clean_chrome_unittests target and tests for the
public and internal APIs of BrowserCoordinator.

BUG=
==========

to

==========
[Clean] Add unittest target and BrowserCoordinator tests.

This CL adds an ios_clean_chrome_unittests target and tests for the
public and internal APIs of BrowserCoordinator.

BUG=

Review-Url: https://codereview.chromium.org/2626033002
Cr-Commit-Position: refs/heads/master@{#443339}
Committed:
https://chromium.googlesource.com/chromium/src/+/6265874469d83f83efc4d6b370d3...
==========

[commit-bot: I haz the power, 2017-01-12 20:21:09]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/6265874469d83f83efc4d6b370d3...