[Clean] Add unittest target and BrowserCoordinator tests.

ios/clean/chrome/browser/browser_coordinator_unittest.mm

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#import "ios/clean/chrome/browser/browser_coordinator.h"
+#import "ios/clean/chrome/browser/browser_coordinator+internal.h"
+
+#include "base/logging.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "testing/gtest_mac.h"
+#include "testing/platform_test.h"
+
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
+@interface TestCoordinator : BrowserCoordinator
+@property(nonatomic) UIViewController* viewController;
+@property(nonatomic, copy) void (^stopHandler)();
+@end
+
+@implementation TestCoordinator
+@synthesize viewController = _viewController;
+@synthesize stopHandler = _stopHandler;
+
+- (instancetype)init {
+  if (!(self = [super init]))
+    return nil;
+
+  _viewController = [[UIViewController alloc] init];
+  return self;
+}
+
+- (void)stop {
+  if (self.stopHandler)
+    self.stopHandler();
+}
+
+@end
+
+@interface NonOverlayableCoordinator : TestCoordinator
+@end
+
+@implementation NonOverlayableCoordinator
+
+- (BOOL)canAddOverlayCoordinator:(BrowserCoordinator*)overlayCoordinator {
+  return NO;
+}
+
+@end
+
+TEST(BrowserCoordinatorTest, TestStopOnDealloc) {
+  __block BOOL called = NO;
+
+  @autoreleasepool {

[lpromero, 2017/01/11 13:29:25]

Why autoreleasepool and not just braces?

[marq (ping after 24h), 2017/01/11 14:06:25]

Done.

+    TestCoordinator* coordinator = [[TestCoordinator alloc] init];
+    coordinator.stopHandler = ^{
+      called = YES;
+    };
+  }
+
+  EXPECT_TRUE(called);
+}
+
+TEST(BrowserCoordinatorTest, TestChildren) {
+  TestCoordinator* parent = [[TestCoordinator alloc] init];
+  TestCoordinator* child = [[TestCoordinator alloc] init];
+
+  [parent addChildCoordinator:child];
+  EXPECT_TRUE([parent.children containsObject:child]);
+  EXPECT_EQ(parent, child.parentCoordinator);
+  EXPECT_EQ(parent.viewController, child.rootViewController);
+
+  [parent removeChildCoordinator:child];
+  EXPECT_FALSE([parent.children containsObject:child]);
+  EXPECT_EQ(nil, child.parentCoordinator);
+  // Unparenting shouldn't change a child's rootViewController.
+  EXPECT_EQ(parent.viewController, child.rootViewController);
+
+  TestCoordinator* otherParent = [[TestCoordinator alloc] init];
+  TestCoordinator* otherChild = [[TestCoordinator alloc] init];
+  [otherParent addChildCoordinator:otherChild];
+
+  // -removeChildCoordinator of a non-child should have no affect.
+  [parent removeChildCoordinator:otherChild];
+  EXPECT_TRUE([otherParent.children containsObject:otherChild]);
+  EXPECT_EQ(otherParent, otherChild.parentCoordinator);
+}
+
+TEST(BrowserCoordinatorTest, TestOverlay) {
+  TestCoordinator* parent = [[TestCoordinator alloc] init];
+  TestCoordinator* child = [[TestCoordinator alloc] init];
+  TestCoordinator* grandchild = [[TestCoordinator alloc] init];
+  TestCoordinator* overlay = [[TestCoordinator alloc] init];
+  TestCoordinator* secondOverlay = [[TestCoordinator alloc] init];
+
+  EXPECT_TRUE([parent canAddOverlayCoordinator:overlay]);
+  [parent addChildCoordinator:child];
+  [child addChildCoordinator:grandchild];
+  EXPECT_FALSE([parent canAddOverlayCoordinator:overlay]);
+  EXPECT_FALSE([child canAddOverlayCoordinator:overlay]);
+  EXPECT_TRUE([grandchild canAddOverlayCoordinator:overlay]);
+  EXPECT_FALSE([grandchild canAddOverlayCoordinator:child]);
+
+  EXPECT_FALSE(overlay.overlaying);
+  [parent addOverlayCoordinator:overlay];
+  EXPECT_TRUE(overlay.overlaying);
+  EXPECT_EQ(overlay, parent.overlayCoordinator);
+  EXPECT_EQ(overlay, child.overlayCoordinator);
+  EXPECT_EQ(overlay, grandchild.overlayCoordinator);
+  EXPECT_TRUE([grandchild.children containsObject:overlay]);
+  EXPECT_EQ(grandchild, overlay.parentCoordinator);
+
+  // Shouldn't be able to add a second overlaying coordinator.
+  EXPECT_FALSE([grandchild canAddOverlayCoordinator:secondOverlay]);
+  EXPECT_FALSE(secondOverlay.overlaying);
+  [parent addOverlayCoordinator:secondOverlay];
+  EXPECT_FALSE(secondOverlay.overlaying);
+
+  [child removeOverlayCoordinator];
+  EXPECT_FALSE(overlay.overlaying);
+  EXPECT_EQ(nil, parent.overlayCoordinator);
+  EXPECT_EQ(nil, child.overlayCoordinator);
+  EXPECT_EQ(nil, grandchild.overlayCoordinator);
+  EXPECT_FALSE([grandchild.children containsObject:overlay]);
+  EXPECT_EQ(nil, overlay.parentCoordinator);
+
+  // An implementation that doesn't allow any overlays shouldn't get one.
+  NonOverlayableCoordinator* noOverlays =
+      [[NonOverlayableCoordinator alloc] init];
+  TestCoordinator* thirdOverlay = [[TestCoordinator alloc] init];
+
+  EXPECT_FALSE([noOverlays canAddOverlayCoordinator:thirdOverlay]);
+  EXPECT_FALSE(thirdOverlay.overlaying);
+  [noOverlays addOverlayCoordinator:thirdOverlay];
+  EXPECT_FALSE(thirdOverlay.overlaying);
+}