Promotes WmWindowMus functions to WmWindowAura and nukes WmWindowMus

Promotes WmWindowMus functions to WmWindowAura and nukes WmWindowMus

WmWindowMus and WmWindowAura only differ in a couple of ways that are
better isolated in WmWindowAura rather than two separate classes.

Next I'm going to rename WmWindowAura to WmWindow.

BUG=671246
TEST=none
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2625873007
Cr-Commit-Position: refs/heads/master@{#443239}
Committed: https://chromium.googlesource.com/chromium/src/+/a8b222fa08f6024ff547f1f35ee219abde6ee511

[sky, 2017-01-11 23:47:31]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 23:48:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2017-01-12 00:01:44]

Description was changed from

==========
Promotes WmWindowMus functions to WmWindowAura to nukes WmWindowMus

WmWindowMus and WmWindowAura only differ in a couple of ways that are
better isolated in WmWindowAura rather than two separate classes.

Next I'm going to rename WmWindowAura to WmWindow.

BUG=671246
TEST=none
R=msw@chromium.org
==========

to

==========
Promotes WmWindowMus functions to WmWindowAura and nukes WmWindowMus

WmWindowMus and WmWindowAura only differ in a couple of ways that are
better isolated in WmWindowAura rather than two separate classes.

Next I'm going to rename WmWindowAura to WmWindow.

BUG=671246
TEST=none
R=msw@chromium.org
==========

[msw, 2017-01-12 00:14:42]

lgtm with some minor qs.

https://codereview.chromium.org/2625873007/diff/20001/ash/aura/wm_window_aura.cc
File ash/aura/wm_window_aura.cc (right):

https://codereview.chromium.org/2625873007/diff/20001/ash/aura/wm_window_aura...
ash/aura/wm_window_aura.cc:732:
Shell::window_manager_client()->RequestClose(aura_window());
q: Should this DCHECK Shell::window_manager_client()?

https://codereview.chromium.org/2625873007/diff/20001/ash/mus/bridge/wm_looku...
File ash/mus/bridge/wm_lookup_mus.cc (right):

https://codereview.chromium.org/2625873007/diff/20001/ash/mus/bridge/wm_looku...
ash/mus/bridge/wm_lookup_mus.cc:32: return
ash::WmWindowAura::Get(widget->GetNativeWindow());
q: is ash:: needed here and elsewhere in this CL in the ash::mus namespace?

https://codereview.chromium.org/2625873007/diff/20001/ash/shell.h
File ash/shell.h (right):

https://codereview.chromium.org/2625873007/diff/20001/ash/shell.h#newcode189
ash/shell.h:189: // TODO(sky): move this and WindowManagerClient into ShellMash
that is owned
q: What is ShellMash? WmShell?

[commit-bot: I haz the power, 2017-01-12 01:19:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 01:19:39]

Dry run: This issue passed the CQ dry run.

[sky, 2017-01-12 14:42:14]

The CQ bit was checked by sky@chromium.org

[sky, 2017-01-12 14:42:14]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2625873007/#ps40001
(title: "merge")

[commit-bot: I haz the power, 2017-01-12 14:42:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2017-01-12 14:43:45]

https://codereview.chromium.org/2625873007/diff/20001/ash/aura/wm_window_aura.cc
File ash/aura/wm_window_aura.cc (right):

https://codereview.chromium.org/2625873007/diff/20001/ash/aura/wm_window_aura...
ash/aura/wm_window_aura.cc:732:
Shell::window_manager_client()->RequestClose(aura_window());
On 2017/01/12 00:14:42, msw wrote:
> q: Should this DCHECK Shell::window_manager_client()?

Done.

https://codereview.chromium.org/2625873007/diff/20001/ash/mus/bridge/wm_looku...
File ash/mus/bridge/wm_lookup_mus.cc (right):

https://codereview.chromium.org/2625873007/diff/20001/ash/mus/bridge/wm_looku...
ash/mus/bridge/wm_lookup_mus.cc:32: return
ash::WmWindowAura::Get(widget->GetNativeWindow());
On 2017/01/12 00:14:42, msw wrote:
> q: is ash:: needed here and elsewhere in this CL in the ash::mus namespace?

Yes. I got all sorts of compile errors without it.

https://codereview.chromium.org/2625873007/diff/20001/ash/shell.h
File ash/shell.h (right):

https://codereview.chromium.org/2625873007/diff/20001/ash/shell.h#newcode189
ash/shell.h:189: // TODO(sky): move this and WindowManagerClient into ShellMash
that is owned
On 2017/01/12 00:14:42, msw wrote:
> q: What is ShellMash? WmShell?

WmShell will go away soon. When that happens we'll want to move bits of Shell
that are applicable to a specific environment off this class. I'm thinking those
are named ShellCash and ShellMash. Those names aren't set in stone.

[commit-bot: I haz the power, 2017-01-12 15:47:18]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484232134097960,
"parent_rev": "0e654809e356d38cdca4b57904bba2a85dd260f2", "commit_rev":
"a8b222fa08f6024ff547f1f35ee219abde6ee511"}

[commit-bot: I haz the power, 2017-01-12 15:47:53]

Description was changed from

==========
Promotes WmWindowMus functions to WmWindowAura and nukes WmWindowMus

WmWindowMus and WmWindowAura only differ in a couple of ways that are
better isolated in WmWindowAura rather than two separate classes.

Next I'm going to rename WmWindowAura to WmWindow.

BUG=671246
TEST=none
R=msw@chromium.org
==========

to

==========
Promotes WmWindowMus functions to WmWindowAura and nukes WmWindowMus

WmWindowMus and WmWindowAura only differ in a couple of ways that are
better isolated in WmWindowAura rather than two separate classes.

Next I'm going to rename WmWindowAura to WmWindow.

BUG=671246
TEST=none
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2625873007
Cr-Commit-Position: refs/heads/master@{#443239}
Committed:
https://chromium.googlesource.com/chromium/src/+/a8b222fa08f6024ff547f1f35ee2...
==========

[commit-bot: I haz the power, 2017-01-12 15:47:54]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a8b222fa08f6024ff547f1f35ee2...