Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1295)

Issue 2625723002: Fix comment regarding position:relative for table cells (Closed)

Created:
3 years, 11 months ago by smcgruer
Modified:
3 years, 11 months ago
Reviewers:
flackr, eae
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix comment regarding position:relative for table cells Support for position:relative was added back in early 2011, in 23fab7d4abe23de5b2855c4d0313467f2c8e4779, but the comment was never updated to reflect the new code. BUG=679759 Review-Url: https://codereview.chromium.org/2625723002 Cr-Commit-Position: refs/heads/master@{#443369} Committed: https://chromium.googlesource.com/chromium/src/+/1469180ca6e0042310b2288a449531a60e8cc8ce

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
smcgruer
3 years, 11 months ago (2017-01-10 18:36:06 UTC) #4
flackr
lgtm
3 years, 11 months ago (2017-01-11 22:50:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2625723002/1
3 years, 11 months ago (2017-01-11 23:04:34 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/340082)
3 years, 11 months ago (2017-01-11 23:22:33 UTC) #11
smcgruer
Whoops, adding eae for blink OWNERS
3 years, 11 months ago (2017-01-11 23:44:47 UTC) #13
eae
LGTM
3 years, 11 months ago (2017-01-12 21:23:48 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2625723002/1
3 years, 11 months ago (2017-01-12 21:24:52 UTC) #16
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 21:36:52 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1469180ca6e0042310b2288a4495...

Powered by Google App Engine
This is Rietveld 408576698