Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp

Issue 2625723002: Fix comment regarding position:relative for table cells (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com) 4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. 5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc.
6 * All rights reserved. 6 * All rights reserved.
7 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 7 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
8 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org> 8 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
9 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. 9 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved.
10 * (http://www.torchmobile.com/) 10 * (http://www.torchmobile.com/)
(...skipping 311 matching lines...) Expand 10 before | Expand all | Expand 10 after
322 return; 322 return;
323 323
324 // FIXME: Don't support this mutation for pseudo styles like first-letter or 324 // FIXME: Don't support this mutation for pseudo styles like first-letter or
325 // first-line, since it's not completely clear how that should work. 325 // first-line, since it's not completely clear how that should work.
326 if (style.display() == EDisplay::Inline && 326 if (style.display() == EDisplay::Inline &&
327 style.styleType() == PseudoIdNone && 327 style.styleType() == PseudoIdNone &&
328 style.getWritingMode() != parentStyle.getWritingMode()) 328 style.getWritingMode() != parentStyle.getWritingMode())
329 style.setDisplay(EDisplay::InlineBlock); 329 style.setDisplay(EDisplay::InlineBlock);
330 330
331 // After performing the display mutation, check table rows. We do not honor 331 // After performing the display mutation, check table rows. We do not honor
332 // position: relative table rows or cells. This has been established for 332 // position: relative table rows. This has been established for position:
333 // position: relative in CSS2.1 (and caused a crash in containingBlock() on 333 // relative in CSS2.1 (and caused a crash in containingBlock() on some sites).
334 // some sites).
335 if ((style.display() == EDisplay::TableHeaderGroup || 334 if ((style.display() == EDisplay::TableHeaderGroup ||
336 style.display() == EDisplay::TableRowGroup || 335 style.display() == EDisplay::TableRowGroup ||
337 style.display() == EDisplay::TableFooterGroup || 336 style.display() == EDisplay::TableFooterGroup ||
338 style.display() == EDisplay::TableRow) && 337 style.display() == EDisplay::TableRow) &&
339 style.position() == RelativePosition) 338 style.position() == RelativePosition)
340 style.setPosition(StaticPosition); 339 style.setPosition(StaticPosition);
341 340
342 // Cannot support position: sticky for table columns and column groups because 341 // Cannot support position: sticky for table columns and column groups because
343 // current code is only doing background painting through columns / column 342 // current code is only doing background painting through columns / column
344 // groups. 343 // groups.
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
476 style.setDisplay(EDisplay::Block); 475 style.setDisplay(EDisplay::Block);
477 476
478 // Columns don't apply to svg text elements. 477 // Columns don't apply to svg text elements.
479 if (isSVGTextElement(*element)) 478 if (isSVGTextElement(*element))
480 style.clearMultiCol(); 479 style.clearMultiCol();
481 } 480 }
482 adjustStyleForAlignment(style, parentStyle); 481 adjustStyleForAlignment(style, parentStyle);
483 } 482 }
484 483
485 } // namespace blink 484 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698