Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2625683002: Remove fundamentally-broken layouttest for zoom on reload (Closed)

Created:
3 years, 11 months ago by blundell
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Remove fundamentally-broken layouttest for zoom on reload The test being preserved is attempting to test that zoom is preserved on reload. However, the mechanism used to do the zoom is renderer-side rather than browser-side. This mechanism (a) doesn't reflect reality and (b) means that the browser is not informed of the initial zoom, making the test fundamentally broken. It is passing on the tree due to a combination of other bugs (see the discussion on crbug.com/673065 for details). This CL removes the test. It has been replaced by a browsertest that exercises this functionality in a manner reflecting real-world usage. BUG=673065 Review-Url: https://codereview.chromium.org/2612543002 Cr-Commit-Position: refs/heads/master@{#441617} (cherry picked from commit 8872b06af376de3ebc7e96aec1fcbe68dae5d27a) Review-Url: https://codereview.chromium.org/2625683002 . Cr-Commit-Position: refs/branch-heads/2924@{#712} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/af859c2e455484b3c877e6db55c20b4cd4a37113

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
blundell
3 years, 11 months ago (2017-01-10 12:32:15 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
af859c2e455484b3c877e6db55c20b4cd4a37113.

Powered by Google App Engine
This is Rietveld 408576698