Fix calculation of the bubble view height.

Fix calculation of the bubble view height.

BUG=678558
TEST=Notification doesn't overlap with Uber Tray when ChromeVox is
     enabled.

Review-Url: https://codereview.chromium.org/2625663002
Cr-Commit-Position: refs/heads/master@{#442756}
Committed: https://chromium.googlesource.com/chromium/src/+/e2867aed46b3f00f3735d310144d6ef638f8be1a

[yhanada, 2017-01-10 12:00:21]

The CQ bit was checked by yhanada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 12:00:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 12:31:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 12:31:57]

Dry run: This issue passed the CQ dry run.

[yhanada, 2017-01-10 13:20:44]

yhanada@chromium.org changed reviewers:
+ skuhne@chromium.org

[yhanada, 2017-01-10 13:20:45]

skuhne@, please take a look. Thanks!

[Mr4D (OOO till 08-26), 2017-01-10 15:08:26]

lgtm

https://codereview.chromium.org/2625663002/diff/1/ash/common/system/tray/syst...
File ash/common/system/tray/system_tray.cc (right):

https://codereview.chromium.org/2625663002/diff/1/ash/common/system/tray/syst...
ash/common/system/tray/system_tray.cc:681: std::max(0, work_area.bottom() -
bubble_view->GetBoundsInScreen().y());
Just wondering - should there be a minumum height instead of 0?

[yhanada, 2017-01-11 01:18:55]

Thank you for the quick review!

https://codereview.chromium.org/2625663002/diff/1/ash/common/system/tray/syst...
File ash/common/system/tray/system_tray.cc (right):

https://codereview.chromium.org/2625663002/diff/1/ash/common/system/tray/syst...
ash/common/system/tray/system_tray.cc:681: std::max(0, work_area.bottom() -
bubble_view->GetBoundsInScreen().y());
On 2017/01/10 15:08:26, Mr4D wrote:
> Just wondering - should there be a minumum height instead of 0?

This height doesn't include a height of tray. I think there is no problem that a
minimum height is 0 when no bubble view (e.g. message center or menu) is shown.

[yhanada, 2017-01-11 01:19:02]

The CQ bit was checked by yhanada@chromium.org

[commit-bot: I haz the power, 2017-01-11 01:19:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 01:24:51]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484097542247970, "parent_rev":
"506bf2924d4de457f71448594c43c79315b86783", "commit_rev":
"e2867aed46b3f00f3735d310144d6ef638f8be1a"}

[commit-bot: I haz the power, 2017-01-11 01:25:18]

Description was changed from

==========
Fix calculation of the bubble view height.

BUG=678558
TEST=Notification doesn't overlap with Uber Tray when ChromeVox is
     enabled.
==========

to

==========
Fix calculation of the bubble view height.

BUG=678558
TEST=Notification doesn't overlap with Uber Tray when ChromeVox is
     enabled.

Review-Url: https://codereview.chromium.org/2625663002
Cr-Commit-Position: refs/heads/master@{#442756}
Committed:
https://chromium.googlesource.com/chromium/src/+/e2867aed46b3f00f3735d310144d...
==========

[commit-bot: I haz the power, 2017-01-11 01:25:19]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e2867aed46b3f00f3735d310144d...