Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Unified Diff: ash/common/system/tray/system_tray.cc

Issue 2625663002: Fix calculation of the bubble view height. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/common/system/tray/system_tray.cc
diff --git a/ash/common/system/tray/system_tray.cc b/ash/common/system/tray/system_tray.cc
index 27609771d7d4feceac7ad6445c193a27aa089627..4ca6308eb5a31c5375d616fe76ca4aae1d297ead 100644
--- a/ash/common/system/tray/system_tray.cc
+++ b/ash/common/system/tray/system_tray.cc
@@ -678,7 +678,7 @@ void SystemTray::UpdateWebNotifications() {
->GetDisplayNearestWindow(bubble_view->GetWidget()->GetNativeView())
.work_area();
height =
- std::max(0, work_area.height() - bubble_view->GetBoundsInScreen().y());
+ std::max(0, work_area.bottom() - bubble_view->GetBoundsInScreen().y());
Mr4D (OOO till 08-26) 2017/01/10 15:08:26 Just wondering - should there be a minumum height
yhanada 2017/01/11 01:18:55 This height doesn't include a height of tray. I th
}
if (web_notification_tray_)
web_notification_tray_->SetTrayBubbleHeight(height);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698