Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2625423003: [ios] Fix settings switch accessibility value and hint (Closed)

Created:
3 years, 11 months ago by sczs
Modified:
3 years, 11 months ago
Reviewers:
edchin, lpromero
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Fix settings switch accessibility value and hint. BUG=671559 Review-Url: https://codereview.chromium.org/2625423003 Cr-Commit-Position: refs/heads/master@{#443524} Committed: https://chromium.googlesource.com/chromium/src/+/29ab9e2ce5544edc156a4d7450c172fb517cb5f3

Patch Set 1 #

Total comments: 9
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -6 lines) Patch
M ios/chrome/app/strings/ios_strings.grd View 1 chunk +3 lines, -0 lines 4 comments Download
M ios/chrome/browser/ui/collection_view/cells/collection_view_switch_item.mm View 5 chunks +14 lines, -3 lines 1 comment Download
M ios/chrome/browser/ui/settings/cells/sync_switch_item.mm View 5 chunks +14 lines, -3 lines 4 comments Download

Messages

Total messages: 12 (5 generated)
sczs
PTAL I think these are the 2 Items that contain switches. If you know of ...
3 years, 11 months ago (2017-01-12 21:45:18 UTC) #3
edchin
https://codereview.chromium.org/2625423003/diff/1/ios/chrome/app/strings/ios_strings.grd File ios/chrome/app/strings/ios_strings.grd (right): https://codereview.chromium.org/2625423003/diff/1/ios/chrome/app/strings/ios_strings.grd#newcode1201 ios/chrome/app/strings/ios_strings.grd:1201: Double tap to toggle setting The guidelines suggest not ...
3 years, 11 months ago (2017-01-12 22:13:45 UTC) #4
sczs
https://codereview.chromium.org/2625423003/diff/1/ios/chrome/app/strings/ios_strings.grd File ios/chrome/app/strings/ios_strings.grd (right): https://codereview.chromium.org/2625423003/diff/1/ios/chrome/app/strings/ios_strings.grd#newcode1201 ios/chrome/app/strings/ios_strings.grd:1201: Double tap to toggle setting On 2017/01/12 22:13:45, edchin ...
3 years, 11 months ago (2017-01-12 22:26:18 UTC) #5
edchin
lgtm. Also, I don't know of any other switches in settings. Thanks for fixing this. ...
3 years, 11 months ago (2017-01-12 22:37:54 UTC) #6
lpromero
lgtm https://codereview.chromium.org/2625423003/diff/1/ios/chrome/app/strings/ios_strings.grd File ios/chrome/app/strings/ios_strings.grd (right): https://codereview.chromium.org/2625423003/diff/1/ios/chrome/app/strings/ios_strings.grd#newcode1201 ios/chrome/app/strings/ios_strings.grd:1201: Double tap to toggle setting On 2017/01/12 22:37:54, ...
3 years, 11 months ago (2017-01-13 10:01:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2625423003/1
3 years, 11 months ago (2017-01-13 10:02:00 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 10:12:01 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/29ab9e2ce5544edc156a4d7450c1...

Powered by Google App Engine
This is Rietveld 408576698