Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: ios/chrome/app/strings/ios_strings.grd

Issue 2625423003: [ios] Fix settings switch accessibility value and hint (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/app/strings/ios_strings.grd
diff --git a/ios/chrome/app/strings/ios_strings.grd b/ios/chrome/app/strings/ios_strings.grd
index deb1a90e6a8733c7785d18160f4168c72bc0ee5c..79f0ea2f6cc7ec12783d04c464de6e54dd4fb058 100644
--- a/ios/chrome/app/strings/ios_strings.grd
+++ b/ios/chrome/app/strings/ios_strings.grd
@@ -1197,6 +1197,9 @@ Handoff must also be enabled in the General section of Settings, and your device
<message name="IDS_IOS_SETTING_ON" desc="Generic status label displayed in Settings to show that a setting is currently turned on. [Length: 5em] [iOS only]">
On
</message>
+ <message name="IDS_IOS_TOGGLE_SETTING_SWITCH_ACCESSIBILITY_HINT" desc="Action hint for any switch in settings. This is spoken by VoiceOver. [iOS only]">
+ Double tap to toggle setting
edchin 2017/01/12 22:13:45 The guidelines suggest not to mention 'tap': "Don’
sczs 2017/01/12 22:26:17 I think the difference is that this is a switch, s
edchin 2017/01/12 22:37:54 Acknowledged.
lpromero 2017/01/13 10:01:33 No action needed: I wanted to follow Apple's examp
+ </message>
<message name="IDS_IOS_SHARE_EMAIL_COMPLETE" desc="Message shown when email share has been sent. [Length: Unknown. Keep it short.] [iOS only]">
Mail sent.
</message>

Powered by Google App Engine
This is Rietveld 408576698