Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 2625363002: Simplify visitor marking mode tracking. (Closed)

Created:
3 years, 11 months ago by sof
Modified:
3 years, 11 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify visitor marking mode tracking. Move the marking mode to VisitorHelper<>, so that both Visitor and InlinedGlobalMarkingVisitor can access and reuse it. In order to do so, hoist out Visitor::MarkingMode as an enum class. R= BUG= Review-Url: https://codereview.chromium.org/2625363002 Cr-Commit-Position: refs/heads/master@{#443444} Committed: https://chromium.googlesource.com/chromium/src/+/e0bcd199795d70a6428d4b41860b2589a9c3652a

Patch Set 1 #

Patch Set 2 : one missing VisitorMarkingMode rename #

Patch Set 3 : HeapTest compilation fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -63 lines) Patch
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/InlinedGlobalMarkingVisitor.h View 2 chunks +2 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/MarkingVisitor.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/MarkingVisitorImpl.h View 7 chunks +11 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 3 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Visitor.h View 5 chunks +34 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Visitor.cpp View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
sof
please take a look.
3 years, 11 months ago (2017-01-12 16:12:39 UTC) #10
haraken
LGTM
3 years, 11 months ago (2017-01-12 16:26:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2625363002/40001
3 years, 11 months ago (2017-01-12 21:59:30 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 01:42:43 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e0bcd199795d70a6428d4b41860b...

Powered by Google App Engine
This is Rietveld 408576698