Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Side by Side Diff: third_party/WebKit/Source/platform/heap/Visitor.cpp

Issue 2625363002: Simplify visitor marking mode tracking. (Closed)
Patch Set: HeapTest compilation fix Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/heap/Visitor.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "platform/heap/Visitor.h" 5 #include "platform/heap/Visitor.h"
6 6
7 #include "platform/heap/BlinkGC.h" 7 #include "platform/heap/BlinkGC.h"
8 #include "platform/heap/MarkingVisitor.h" 8 #include "platform/heap/MarkingVisitor.h"
9 #include "platform/heap/ThreadState.h" 9 #include "platform/heap/ThreadState.h"
10 #include "wtf/PtrUtil.h" 10 #include "wtf/PtrUtil.h"
11 #include <memory> 11 #include <memory>
12 12
13 namespace blink { 13 namespace blink {
14 14
15 std::unique_ptr<Visitor> Visitor::create(ThreadState* state, MarkingMode mode) { 15 std::unique_ptr<Visitor> Visitor::create(ThreadState* state,
16 VisitorMarkingMode mode) {
16 return WTF::makeUnique<MarkingVisitor>(state, mode); 17 return WTF::makeUnique<MarkingVisitor>(state, mode);
17 } 18 }
18 19
19 Visitor::Visitor(ThreadState* state, MarkingMode markingMode) 20 Visitor::Visitor(ThreadState* state, VisitorMarkingMode markingMode)
20 : VisitorHelper(state), m_markingMode(markingMode) { 21 : VisitorHelper(state, markingMode) {
21 // See ThreadState::runScheduledGC() why we need to already be in a 22 // See ThreadState::runScheduledGC() why we need to already be in a
22 // GCForbiddenScope before any safe point is entered. 23 // GCForbiddenScope before any safe point is entered.
23 DCHECK(state->isGCForbidden()); 24 DCHECK(state->isGCForbidden());
24 #if ENABLE(ASSERT) 25 #if ENABLE(ASSERT)
25 DCHECK(state->checkThread()); 26 DCHECK(state->checkThread());
26 #endif 27 #endif
27 } 28 }
28 29
29 Visitor::~Visitor() {} 30 Visitor::~Visitor() {}
30 31
31 } // namespace blink 32 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/platform/heap/Visitor.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698