Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2625313002: CSS: Rotate support for none and fixed responsive-test.js (Closed)

Created:
3 years, 11 months ago by divyanshi
Modified:
3 years, 10 months ago
CC:
chromium-reviews, shans, rjwright, blink-reviews-style_chromium.org, blink-reviews-animation_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CSS: Rotate support for none and fixed responsive-test.js The initial value for rotate is none not 0deg. https://drafts.csswg.org/css-transforms-2/#individual-transforms Responsive test was not checking that the property value was valid. Also added a parsing test for scale. [This CL was landed by Eric Willigers as https://codereview.chromium.org/2662203002.] BUG=679873

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -17 lines) Patch
M third_party/WebKit/LayoutTests/animations/responsive/resources/responsive-test.js View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/animations/responsive/rotate-responsive.html View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/animations/responsive/transform-responsive.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-listing-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/svg/css/getComputedStyle-listing-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/transforms/rotate-parsing.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/transforms/scale-parsing.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
divyanshi
3 years, 11 months ago (2017-01-12 04:39:39 UTC) #2
alancutter (OOO until 2018)
Add new test cases to rotate-interpolation.html.
3 years, 11 months ago (2017-01-12 04:45:58 UTC) #3
Eric Willigers
On 2017/01/12 04:45:58, alancutter wrote: > Add new test cases to rotate-interpolation.html. In https://codereview.chromium.org/2620263002/ I ...
3 years, 11 months ago (2017-01-12 05:02:00 UTC) #4
alancutter (OOO until 2018)
On 2017/01/12 at 05:02:00, ericwilligers wrote: > On 2017/01/12 04:45:58, alancutter wrote: > > Add ...
3 years, 11 months ago (2017-01-12 05:09:26 UTC) #5
Eric Willigers
3 years, 10 months ago (2017-02-14 02:36:23 UTC) #10
On 2017/01/12 05:09:26, alancutter wrote:
> On 2017/01/12 at 05:02:00, ericwilligers wrote:
> > On 2017/01/12 04:45:58, alancutter wrote:
> > > Add new test cases to rotate-interpolation.html.
> > 
> > In https://codereview.chromium.org/2620263002/  I suggested this be a later
> patch. 
> > 
> > We smoothly interpolated between initial and 90deg when initial was 0deg
> (stored internally as nullptr). With this patch we still smoothly interpolate
> between initial and 90deg.
> 
> Adding the tests is not a big change, it should be part of this patch. If
> anything should be separate it's the CSS.supports() change.

I added tests and landed this as https://codereview.chromium.org/2662203002.

Powered by Google App Engine
This is Rietveld 408576698