Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp

Issue 2625313002: CSS: Rotate support for none and fixed responsive-test.js (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
diff --git a/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp b/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
index 0311e4d2f9438907fe57c8f07dc7d9cd86680c6a..8926c6e555c8eb78eacf037f5c2d92f82b89f8ae 100644
--- a/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
+++ b/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
@@ -1240,6 +1240,11 @@ Rotation StyleBuilderConverter::convertRotation(const CSSValue& value) {
PassRefPtr<RotateTransformOperation> StyleBuilderConverter::convertRotate(
StyleResolverState& state,
const CSSValue& value) {
+ if (value.isIdentifierValue()) {
+ DCHECK_EQ(toCSSIdentifierValue(value).getValueID(), CSSValueNone);
+ return nullptr;
+ }
+
return RotateTransformOperation::create(convertRotation(value),
TransformOperation::Rotate3D);
}
« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698