Fix CSSPropertySetterGetterMethods regression

Fix CSSPropertySetterGetterMethods regression

A recent patch crrev.com/2607403002 introduced a 10% regression in
setters and getters for CSSOM style objects. This patch fixes this
by removing the additional binding to access the registry, instead
using already existing members to access it.

BUG=679511
Review-Url: https://codereview.chromium.org/2625303002
Cr-Commit-Position: refs/heads/master@{#443188}
Committed: https://chromium.googlesource.com/chromium/src/+/2dcda31b3f6d9e8cf588f0c233d9c8c7cb9b4521

[Timothy Loh, 2017-01-12 04:15:24]

The CQ bit was checked by timloh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 04:15:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Timothy Loh, 2017-01-12 04:38:58]

Description was changed from

==========
not for review (it's for perf try bot)
==========

to

==========
Fix CSSPropertySetterGetterMethods regression

A recent patch crrev.com/2607403002 introduced a 10% regression in
setters and getters for CSSOM style objects. This patch fixes this
by removing the additional binding to access the registry, instead
using already existing members to access it.

BUG=679511
==========

[Timothy Loh, 2017-01-12 04:38:59]

timloh@chromium.org changed reviewers:
+ alancutter@chromium.org

[Timothy Loh, 2017-01-12 04:44:41]

The description says this fixes the regression but I'm waiting for the perf bots
to actually verify this.

https://codereview.chromium.org/2625303002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.h
(right):

https://codereview.chromium.org/2625303002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.h:101:
PropertyRegistry* propertyRegistry() const override { return nullptr; }
This is because for some reason we create PropertySetCSSStyleDeclaration objects
from MutableStylePropertySet::ensureCSSStyleDeclaration(), which is called by
editing and by the inspector (only for attribute style, so no custom
properties). It seems like editing doesn't do anything that will need this but
I'm not entirely sure.

[alancutter (OOO until 2018), 2017-01-12 04:49:05]

I wonder if this change is actually more correct than before when there are
multiple documents involved.

Please ping this if perf results confirm unregression.

[commit-bot: I haz the power, 2017-01-12 05:53:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 05:53:34]

Dry run: This issue passed the CQ dry run.

[Timothy Loh, 2017-01-12 05:58:55]

On 2017/01/12 04:49:05, alancutter wrote:
> I wonder if this change is actually more correct than before when there are
> multiple documents involved.
> 
> Please ping this if perf results confirm unregression.

Without patch: avg 338.80557206378126 runs/s
With patch: avg 383.15427294640705 runs/s

Looks fixed :)

[alancutter (OOO until 2018), 2017-01-12 07:01:23]

lgtm

[haraken, 2017-01-12 07:06:05]

bindings/ LGTM

[Timothy Loh, 2017-01-12 08:55:28]

The CQ bit was checked by timloh@chromium.org

[commit-bot: I haz the power, 2017-01-12 08:55:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 09:00:36]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484211328544820,
"parent_rev": "5a502c1929dcc9274c0a51af5b249259a59dd759", "commit_rev":
"2dcda31b3f6d9e8cf588f0c233d9c8c7cb9b4521"}

[commit-bot: I haz the power, 2017-01-12 09:01:08]

Description was changed from

==========
Fix CSSPropertySetterGetterMethods regression

A recent patch crrev.com/2607403002 introduced a 10% regression in
setters and getters for CSSOM style objects. This patch fixes this
by removing the additional binding to access the registry, instead
using already existing members to access it.

BUG=679511
==========

to

==========
Fix CSSPropertySetterGetterMethods regression

A recent patch crrev.com/2607403002 introduced a 10% regression in
setters and getters for CSSOM style objects. This patch fixes this
by removing the additional binding to access the registry, instead
using already existing members to access it.

BUG=679511

Review-Url: https://codereview.chromium.org/2625303002
Cr-Commit-Position: refs/heads/master@{#443188}
Committed:
https://chromium.googlesource.com/chromium/src/+/2dcda31b3f6d9e8cf588f0c233d9...
==========

[commit-bot: I haz the power, 2017-01-12 09:01:10]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2dcda31b3f6d9e8cf588f0c233d9...