third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp - Issue 2625303002: Fix CSSPropertySetterGetterMethods regression

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

Issue 2625303002: Fix CSSPropertySetterGetterMethods regression (Closed)

Patch Set: fix Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.h ('K') | « third_party/WebKit/Source/core/editing/commands/RemoveCSSPropertyCommand.cpp ('k') | third_party/WebKit/Source/core/html/HTMLMarqueeElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp b/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

index 5ed814d50ebcc68c5d53ba7d7eb9291dbce41f97..2a32bca17696016979095378fd18a9e0070696ac 100644

--- a/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

@@ -689,13 +689,13 @@ void ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline(

// script.

if (isEnclosingBlock(element)) {

element->style()->setPropertyInternal(CSSPropertyDisplay, String(),

- "inline", false, nullptr,

+ "inline", false,

IGNORE_EXCEPTION_FOR_TESTING);

}

if (element->layoutObject() &&

element->layoutObject()->style()->isFloating()) {

element->style()->setPropertyInternal(CSSPropertyFloat, String(),

- "none", false, nullptr,

+ "none", false,

IGNORE_EXCEPTION_FOR_TESTING);

}