Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Unified Diff: ios/web/app/web_main_loop.mm

Issue 2625213003: Rename *FileIO TaskScheduler worker pools to *Blocking. (Closed)
Patch Set: update dates Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web/app/web_main_loop.mm
diff --git a/ios/web/app/web_main_loop.mm b/ios/web/app/web_main_loop.mm
index a378af7cfed67a9e6f83f55618630292a42229a4..54812596f2c8e65c8e95188a3046826c023d8999 100644
--- a/ios/web/app/web_main_loop.mm
+++ b/ios/web/app/web_main_loop.mm
@@ -40,9 +40,9 @@ namespace {
enum WorkerPoolType : size_t {
BACKGROUND = 0,
- BACKGROUND_FILE_IO,
+ BACKGROUND_BLOCKING,
FOREGROUND,
- FOREGROUND_FILE_IO,
+ FOREGROUND_BLOCKING,
WORKER_POOL_COUNT // Always last.
};
@@ -57,7 +57,8 @@ GetDefaultSchedulerWorkerPoolParams() {
base::RecommendedMaxNumberOfThreadsInPool(2, 8, 0.1, 0),
base::TimeDelta::FromSeconds(30));
params_vector.emplace_back(
- "BackgroundFileIO", ThreadPriority::BACKGROUND, StandbyThreadPolicy::ONE,
+ "BackgroundBlocking", ThreadPriority::BACKGROUND,
+ StandbyThreadPolicy::ONE,
base::RecommendedMaxNumberOfThreadsInPool(2, 8, 0.1, 0),
base::TimeDelta::FromSeconds(30));
params_vector.emplace_back(
@@ -65,21 +66,21 @@ GetDefaultSchedulerWorkerPoolParams() {
base::RecommendedMaxNumberOfThreadsInPool(3, 8, 0.3, 0),
base::TimeDelta::FromSeconds(30));
params_vector.emplace_back(
- "ForegroundFileIO", ThreadPriority::NORMAL, StandbyThreadPolicy::ONE,
- base::RecommendedMaxNumberOfThreadsInPool(3, 8, 0.1, 0),
+ "ForegroundBlocking", ThreadPriority::NORMAL, StandbyThreadPolicy::ONE,
+ base::RecommendedMaxNumberOfThreadsInPool(3, 8, 0.3, 0),
fdoray 2017/02/16 16:27:40 0.1 -> 0.3 to match the existing server default co
base::TimeDelta::FromSeconds(30));
DCHECK_EQ(WORKER_POOL_COUNT, params_vector.size());
return params_vector;
}
// Returns the worker pool index for |traits| defaulting to FOREGROUND or
-// FOREGROUND_FILE_IO on any other priorities based off of worker pools defined
+// FOREGROUND_BLOCKING on any other priorities based off of worker pools defined
// in GetDefaultSchedulerWorkerPoolParams().
size_t DefaultBrowserWorkerPoolIndexForTraits(const base::TaskTraits& traits) {
const bool is_background =
traits.priority() == base::TaskPriority::BACKGROUND;
if (traits.may_block() || traits.with_base_sync_primitives())
- return is_background ? BACKGROUND_FILE_IO : FOREGROUND_FILE_IO;
+ return is_background ? BACKGROUND_BLOCKING : FOREGROUND_BLOCKING;
return is_background ? BACKGROUND : FOREGROUND;
}

Powered by Google App Engine
This is Rietveld 408576698