iOS: Add the Page Info password/credit card string for HTTP pages.

iOS: Add the Page Info password/credit card string for HTTP pages.

This also updates the "What do these mean?" link to "Learn more" to match Desktop material design.

BUG=656843
Review-Url: https://codereview.chromium.org/2624963004
Cr-Commit-Position: refs/heads/master@{#444114}
Committed: https://chromium.googlesource.com/chromium/src/+/86e86920236731fba6385c479cf27fd6c0d15655

[lgarron, 2017-01-12 02:00:35]

lgarron@chromium.org changed reviewers:
+ rohitrao@chromium.org

[lgarron, 2017-01-12 02:00:35]

rohitrao@, could you review?

[lgarron, 2017-01-12 02:00:46]

The CQ bit was checked by lgarron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 02:01:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 02:13:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 02:13:17]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[lgarron, 2017-01-12 02:21:25]

The CQ bit was checked by lgarron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 02:21:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 02:33:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 02:33:15]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[lgarron, 2017-01-12 03:06:01]

The CQ bit was checked by lgarron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 03:06:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 03:12:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 03:12:11]

Dry run: This issue passed the CQ dry run.

[rohitrao (ping after 24h), 2017-01-16 13:11:09]

lgtm

[rohitrao (ping after 24h), 2017-01-16 13:12:46]

Which part of this CL is adding the password/creditcard strings?

[lgarron, 2017-01-17 19:34:02]

On 2017/01/16 at 13:12:46, rohitrao wrote:
> Which part of this CL is adding the password/creditcard strings?

IDS_PAGEINFO_NOT_SECURE_DETAILS [1] is: "You should not enter any sensitive
information on this site (for example, passwords or credit cards), because it
could be stolen by attackers."
(The strings was moved to the Page Info strings file in the dependent CL:
https://codereview.chromium.org/2620123003)

[1]
https://cs.chromium.org/chromium/src/components/pageinfo_strings.grdp?q=IDS_P...

[lgarron, 2017-01-17 19:34:07]

The CQ bit was checked by lgarron@chromium.org

[commit-bot: I haz the power, 2017-01-17 19:34:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 19:49:18]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484681647081370, "parent_rev":
"701e43f0444b6bd25f7a58acb5ebe87138ffec04", "commit_rev":
"86e86920236731fba6385c479cf27fd6c0d15655"}

[commit-bot: I haz the power, 2017-01-17 19:49:47]

Description was changed from

==========
iOS: Add the Page Info password/credit card string for HTTP pages.

This also updates the "What do these mean?" link to "Learn more" to match
Desktop material design.

BUG=656843
==========

to

==========
iOS: Add the Page Info password/credit card string for HTTP pages.

This also updates the "What do these mean?" link to "Learn more" to match
Desktop material design.

BUG=656843

Review-Url: https://codereview.chromium.org/2624963004
Cr-Commit-Position: refs/heads/master@{#444114}
Committed:
https://chromium.googlesource.com/chromium/src/+/86e86920236731fba6385c479cf2...
==========

[commit-bot: I haz the power, 2017-01-17 19:49:48]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/86e86920236731fba6385c479cf2...