Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 2620123003: Move Page Info security summary and detail strings into `pageinfo_strings.grdp`. (Closed)

Created:
3 years, 11 months ago by lgarron
Modified:
3 years, 11 months ago
CC:
chromium-reviews, markusheintz_, msramek+watch_chromium.org, raymes+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move Page Info security summary and detail strings into `pageinfo_strings.grdp`. This allows them to be used on iOS. This CL also makes estark@ and lgarron@ owners of page info strings. BUG=679976 Review-Url: https://codereview.chromium.org/2620123003 Cr-Commit-Position: refs/heads/master@{#443137} Committed: https://chromium.googlesource.com/chromium/src/+/a0a14a480f4d26064ec659eab3f2d8b9e4ac0c33

Patch Set 1 #

Patch Set 2 : OWNERS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -57 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -40 lines 0 comments Download
M chrome/browser/ui/website_settings/website_settings.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/website_settings/website_settings_ui.cc View 1 chunk +14 lines, -14 lines 0 comments Download
M components/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M components/pageinfo_strings.grdp View 1 chunk +43 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (10 generated)
lgarron
jochen@, could you review the string move/ estark@, could you review website_settings? Also, are you ...
3 years, 11 months ago (2017-01-11 03:23:45 UTC) #3
jochen (gone - plz use gerrit)
lgtm
3 years, 11 months ago (2017-01-11 09:55:03 UTC) #4
lgarron
estark@, could you review website_settings (even if Jochen's LGTM covers it)? Also, are you okay ...
3 years, 11 months ago (2017-01-12 00:06:41 UTC) #6
estark
lgtm
3 years, 11 months ago (2017-01-12 02:09:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2620123003/20001
3 years, 11 months ago (2017-01-12 02:55:00 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 03:04:47 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a0a14a480f4d26064ec659eab3f2...

Powered by Google App Engine
This is Rietveld 408576698