[Sync] Move snapshot cache from SBHI to PSS.

[Sync] Move snapshot cache from SBHI to PSS.

This is part of an effort to remove all business logic from SBHI.

BUG=669967
Review-Url: https://codereview.chromium.org/2624943002
Cr-Commit-Position: refs/heads/master@{#443488}
Committed: https://chromium.googlesource.com/chromium/src/+/cbd47621a175445abb1ad2c96e66b98fc8b93eba

[maxbogue, 2017-01-11 22:17:42]

maxbogue@chromium.org changed reviewers:
+ pavely@chromium.org

[maxbogue, 2017-01-11 22:17:43]

Pavel, PTAL!

[maxbogue, 2017-01-11 22:17:53]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 22:19:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 23:27:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 23:27:09]

Dry run: This issue passed the CQ dry run.

[pavely, 2017-01-12 00:27:13]

lgtm

https://codereview.chromium.org/2624943002/diff/1/components/browser_sync/pro...
File components/browser_sync/profile_sync_service.cc (right):

https://codereview.chromium.org/2624943002/diff/1/components/browser_sync/pro...
components/browser_sync/profile_sync_service.cc:1875: return last_snapshot_;
Previously if user signs out this method would return default snapshot. Now it
will return last snapshot. I guess there should be no harm in it.

https://codereview.chromium.org/2624943002/diff/1/components/sync/engine/sync...
File components/sync/engine/sync_engine.h (left):

https://codereview.chromium.org/2624943002/diff/1/components/sync/engine/sync...
components/sync/engine/sync_engine.h:143: // summarized form.
GetLastCycleSnapshot() was that summarized form mentioned in comment. Could you
adjust comment.

[maxbogue, 2017-01-12 01:55:02]

https://codereview.chromium.org/2624943002/diff/1/components/browser_sync/pro...
File components/browser_sync/profile_sync_service.cc (right):

https://codereview.chromium.org/2624943002/diff/1/components/browser_sync/pro...
components/browser_sync/profile_sync_service.cc:1875: return last_snapshot_;
On 2017/01/12 00:27:13, pavely wrote:
> Previously if user signs out this method would return default snapshot. Now it
> will return last snapshot. I guess there should be no harm in it.

Hmm... I'm going to clear it in ShutdownImpl just to be safe.

https://codereview.chromium.org/2624943002/diff/1/components/sync/engine/sync...
File components/sync/engine/sync_engine.h (left):

https://codereview.chromium.org/2624943002/diff/1/components/sync/engine/sync...
components/sync/engine/sync_engine.h:143: // summarized form.
On 2017/01/12 00:27:13, pavely wrote:
> GetLastCycleSnapshot() was that summarized form mentioned in comment. Could
you
> adjust comment.

Done.

[maxbogue, 2017-01-12 01:55:05]

The CQ bit was checked by maxbogue@chromium.org

[maxbogue, 2017-01-12 01:55:06]

The patchset sent to the CQ was uploaded after l-g-t-m from pavely@chromium.org
Link to the patchset: https://codereview.chromium.org/2624943002/#ps20001
(title: "Address comments.")

[commit-bot: I haz the power, 2017-01-12 01:55:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 02:05:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 02:05:06]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[maxbogue, 2017-01-12 22:24:12]

The CQ bit was checked by maxbogue@chromium.org

[commit-bot: I haz the power, 2017-01-12 22:24:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 04:24:21]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484259852086740,
"parent_rev": "497dcf0daf5f6e6bc8b644d85a75a6816305b93a", "commit_rev":
"cbd47621a175445abb1ad2c96e66b98fc8b93eba"}

[commit-bot: I haz the power, 2017-01-13 04:25:14]

Description was changed from

==========
[Sync] Move snapshot cache from SBHI to PSS.

This is part of an effort to remove all business logic from SBHI.

BUG=669967
==========

to

==========
[Sync] Move snapshot cache from SBHI to PSS.

This is part of an effort to remove all business logic from SBHI.

BUG=669967

Review-Url: https://codereview.chromium.org/2624943002
Cr-Commit-Position: refs/heads/master@{#443488}
Committed:
https://chromium.googlesource.com/chromium/src/+/cbd47621a175445abb1ad2c96e66...
==========

[commit-bot: I haz the power, 2017-01-13 04:25:14]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/cbd47621a175445abb1ad2c96e66...