components/sync/engine/sync_engine.h - Issue 2624943002: [Sync] Move snapshot cache from SBHI to PSS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/engine/sync_engine.h

Issue 2624943002: [Sync] Move snapshot cache from SBHI to PSS. (Closed)

Patch Set: Address comments. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/engine/sync_engine.h

diff --git a/components/sync/engine/sync_engine.h b/components/sync/engine/sync_engine.h

index 6c1d9dc7155e59276de5bc4eab9adfeba028735c..af4e53d0b489030cbc8407018440605349b3022b 100644

--- a/components/sync/engine/sync_engine.h

+++ b/components/sync/engine/sync_engine.h

@@ -139,10 +139,8 @@ class SyncEngine : public ModelTypeConfigurer {

// OnBackendInitialized().

virtual UserShare* GetUserShare() const = 0;

- // Called from any thread to obtain current status information in detailed or

- // summarized form.

+ // Called from any thread to obtain current detailed status information.

virtual Status GetDetailedStatus() = 0;

- virtual SyncCycleSnapshot GetLastCycleSnapshot() const = 0;

// Determines if the underlying sync engine has made any local changes to

// items that have not yet been synced with the server.