src/layout-descriptor-inl.h - Issue 2624903003: [runtime] Use PropertyKind/PropertyLocation instead of PropertyType.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/layout-descriptor-inl.h

Issue 2624903003: [runtime] Use PropertyKind/PropertyLocation instead of PropertyType. (Closed)

Patch Set: Addressing comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/layout-descriptor-inl.h

diff --git a/src/layout-descriptor-inl.h b/src/layout-descriptor-inl.h

index bade05e2e8517db654c0adafda7b84eec798c9af..4f193b30e833b9f2e30804219811cb7afac65cc4 100644

--- a/src/layout-descriptor-inl.h

+++ b/src/layout-descriptor-inl.h

@@ -28,7 +28,7 @@ Handle<LayoutDescriptor> LayoutDescriptor::New(Isolate* isolate, int length) {

bool LayoutDescriptor::InobjectUnboxedField(int inobject_properties,

PropertyDetails details) {

- if (details.type() != DATA || !details.representation().IsDouble()) {

+ if (details.location() != kField || !details.representation().IsDouble()) {

return false;

}

// We care only about in-object properties.

« no previous file with comments | « src/keys.cc ('k') | src/lookup.cc » ('j') | no next file with comments »