Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2624833002: Revert of [Offline Pages] Remove need for OfflinePolicy when constructing an Offliner. (Closed)

Created:
3 years, 11 months ago by chili
Modified:
3 years, 11 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, romax+watch_chromium.org, tburkard+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, gavinp+prer_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Offline Pages] Remove need for OfflinePolicy when constructing an Offliner. (patchset #1 id:1 of https://codereview.chromium.org/2624523003/ ) Reason for revert: The policy might be used shortly. This may be too soon Original issue's description: > [Offline Pages] Remove need for OfflinePolicy when constructing an Offliner. > > BUG=679822 > > Review-Url: https://codereview.chromium.org/2624523003 > Cr-Commit-Position: refs/heads/master@{#442687} > Committed: https://chromium.googlesource.com/chromium/src/+/73b5ae5acf62a62a0782eef02086bd7b2b2b3fe4 TBR=dimich@chromium.org,petewil@chromium.org,dougarnett@chromium.org,dewittj@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=679822 Review-Url: https://codereview.chromium.org/2624833002 Cr-Commit-Position: refs/heads/master@{#442696} Committed: https://chromium.googlesource.com/chromium/src/+/8dbcb8957be2763be561ea510da5c4ed9c442da0

Patch Set 1 #

Messages

Total messages: 11 (5 generated)
chili
Created Revert of [Offline Pages] Remove need for OfflinePolicy when constructing an Offliner.
3 years, 11 months ago (2017-01-10 21:23:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2624833002/1
3 years, 11 months ago (2017-01-10 21:23:39 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 11 months ago (2017-01-10 21:23:41 UTC) #5
Pete Williamson
lgtm
3 years, 11 months ago (2017-01-10 21:27:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2624833002/1
3 years, 11 months ago (2017-01-10 21:30:38 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 21:33:44 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8dbcb8957be2763be561ea510da5...

Powered by Google App Engine
This is Rietveld 408576698