[Offline Pages] Remove need for OfflinePolicy when constructing an Offliner.

[Offline Pages] Remove need for OfflinePolicy when constructing an Offliner.

BUG=679822
Review-Url: https://codereview.chromium.org/2624523003
Cr-Commit-Position: refs/heads/master@{#442687}
Committed: https://chromium.googlesource.com/chromium/src/+/73b5ae5acf62a62a0782eef02086bd7b2b2b3fe4

[chili, 2017-01-10 00:02:51]

The CQ bit was checked by chili@chromium.org to run a CQ dry run

[chili, 2017-01-10 00:03:53]

chili@chromium.org changed reviewers:
+ dimich@chromium.org, dougarnett@chromium.org, petewil@chromium.org

[commit-bot: I haz the power, 2017-01-10 00:03:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chili, 2017-01-10 00:03:54]

Follow-up from previous CL

[Dmitry Titov, 2017-01-10 00:18:10]

Yay! LGTM

[commit-bot: I haz the power, 2017-01-10 03:39:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 03:39:58]

Dry run: This issue passed the CQ dry run.

[chili, 2017-01-10 19:24:43]

friendly poke to doug & pete if you've any reservations about this change :)

[dewittj, 2017-01-10 19:33:45]

dewittj@chromium.org changed reviewers:
+ dewittj@chromium.org

[dewittj, 2017-01-10 19:33:45]

drive-by lgtm - Please can you find a bug for this change?

[chili, 2017-01-10 19:45:02]

Description was changed from

==========
[Offline Pages] Remove need for OfflinePolicy when constructing an Offliner.

BUG=
==========

to

==========
[Offline Pages] Remove need for OfflinePolicy when constructing an Offliner.

BUG=679822
==========

[chili, 2017-01-10 19:45:20]

On 2017/01/10 19:33:45, dewittj wrote:
> drive-by lgtm - Please can you find a bug for this change?

Created crbug/679822

[chili, 2017-01-10 21:09:48]

The CQ bit was checked by chili@chromium.org

[commit-bot: I haz the power, 2017-01-10 21:10:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 21:15:23]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484082588829980, "parent_rev":
"6c7b5cf2a6f4ec67e245712e9ae7ebb6a080afeb", "commit_rev":
"73b5ae5acf62a62a0782eef02086bd7b2b2b3fe4"}

[commit-bot: I haz the power, 2017-01-10 21:15:58]

Description was changed from

==========
[Offline Pages] Remove need for OfflinePolicy when constructing an Offliner.

BUG=679822
==========

to

==========
[Offline Pages] Remove need for OfflinePolicy when constructing an Offliner.

BUG=679822

Review-Url: https://codereview.chromium.org/2624523003
Cr-Commit-Position: refs/heads/master@{#442687}
Committed:
https://chromium.googlesource.com/chromium/src/+/73b5ae5acf62a62a0782eef02086...
==========

[commit-bot: I haz the power, 2017-01-10 21:15:59]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/73b5ae5acf62a62a0782eef02086...

[Pete Williamson, 2017-01-10 21:17:12]

I'm not sure we should land this, Romax is planning to land a change soon that
needs the policy object, and he'd just have to undo this change.

The idea is to take a snapshot on the last timeout, and we would need to use the
policy object to keep track of which is the last timeout.

Could we not check this in for now? (maybe we could do it later if Romax ends up
not using the policy object after all)

not lgtm

not lgtm

[chili, 2017-01-10 21:21:37]

On 2017/01/10 21:17:12, Pete Williamson wrote:
> I'm not sure we should land this, Romax is planning to land a change soon that
> needs the policy object, and he'd just have to undo this change.
> 
> The idea is to take a snapshot on the last timeout, and we would need to use
the
> policy object to keep track of which is the last timeout.
> 
> Could we not check this in for now? (maybe we could do it later if Romax ends
up
> not using the policy object after all)
> 
> not lgtm
> 
> not lgtm

uhh... crap... i'll roll back?

[chili, 2017-01-10 21:23:01]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2624833002/ by chili@chromium.org.

The reason for reverting is: The policy might be used shortly. This may be too
soon.

[jam, 2017-01-10 21:58:32]

btw this caused a bunch of flakiness:
https://bugs.chromium.org/p/chromium/issues/detail?id=679844