Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Unified Diff: src/asmjs/asm-js.cc

Issue 2624813002: [wasm][asm.js] Enable --validate-asm by default. (Closed)
Patch Set: fix Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/flag-definitions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/asmjs/asm-js.cc
diff --git a/src/asmjs/asm-js.cc b/src/asmjs/asm-js.cc
index 9508b489545a408c2c2ae1738f6ba99b56248e2c..496b1bc806a33d2c1f0d223bb594c400b0cd1121 100644
--- a/src/asmjs/asm-js.cc
+++ b/src/asmjs/asm-js.cc
@@ -212,15 +212,9 @@ MaybeHandle<FixedArray> AsmJs::CompileAsmViaWasm(CompilationInfo* info) {
MessageLocation location(info->script(), info->literal()->position(),
info->literal()->position());
char text[100];
- int length;
- if (FLAG_trace_asm_time) {
- length =
- base::OS::SNPrintF(text, arraysize(text),
- "success, asm->wasm: %0.3f ms, compile: %0.3f ms",
- asm_wasm_time, compile_time);
- } else {
- length = base::OS::SNPrintF(text, arraysize(text), "success");
- }
+ int length = base::OS::SNPrintF(
+ text, arraysize(text), "success, asm->wasm: %0.3f ms, compile: %0.3f ms",
+ asm_wasm_time, compile_time);
DCHECK_NE(-1, length);
USE(length);
Handle<String> stext(info->isolate()->factory()->InternalizeUtf8String(text));
@@ -228,7 +222,7 @@ MaybeHandle<FixedArray> AsmJs::CompileAsmViaWasm(CompilationInfo* info) {
info->isolate(), MessageTemplate::kAsmJsCompiled, &location, stext,
Handle<JSArray>::null());
message->set_error_level(v8::Isolate::kMessageInfo);
- if (!FLAG_suppress_asm_messages) {
+ if (!FLAG_suppress_asm_messages && FLAG_trace_asm_time) {
MessageHandler::ReportMessage(info->isolate(), &location, message);
}
@@ -327,13 +321,9 @@ MaybeHandle<Object> AsmJs::InstantiateAsmWasm(i::Isolate* isolate,
}
MessageLocation location(script, position, position);
char text[50];
- int length;
- if (FLAG_trace_asm_time) {
- length = base::OS::SNPrintF(text, arraysize(text), "success, %0.3f ms",
- instantiate_timer.Elapsed().InMillisecondsF());
- } else {
- length = base::OS::SNPrintF(text, arraysize(text), "success");
- }
+ int length =
+ base::OS::SNPrintF(text, arraysize(text), "success, %0.3f ms",
+ instantiate_timer.Elapsed().InMillisecondsF());
DCHECK_NE(-1, length);
USE(length);
Handle<String> stext(isolate->factory()->InternalizeUtf8String(text));
@@ -341,7 +331,9 @@ MaybeHandle<Object> AsmJs::InstantiateAsmWasm(i::Isolate* isolate,
isolate, MessageTemplate::kAsmJsInstantiated, &location, stext,
Handle<JSArray>::null());
message->set_error_level(v8::Isolate::kMessageInfo);
- MessageHandler::ReportMessage(isolate, &location, message);
+ if (!FLAG_suppress_asm_messages && FLAG_trace_asm_time) {
+ MessageHandler::ReportMessage(isolate, &location, message);
+ }
return module_object;
}
« no previous file with comments | « no previous file | src/flag-definitions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698