Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2624713002: Revert of [WASM] Fix failing Wasm SIMD F32x4 tests. (Closed)

Created:
3 years, 11 months ago by bbudge
Modified:
3 years, 11 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [WASM] Fix failing Wasm SIMD F32x4 tests. (patchset #7 id:130001 of https://codereview.chromium.org/2594043002/ ) Reason for revert: F32x4Add / Sub are still failing. I'll have to investigate on ARM hardware when I get back. Original issue's description: > [WASM] Fix failing Wasm SIMD F32x4 tests. > - Perform lane checks using FP compare instead of reinterpret casts. 0 and -0 > will be different under I32 compare. > - Some arithmetic operations can generate NaN results, such as adding -Inf > and +Inf. Skip these tests until we have a way to do more sophisticated > FP comparisons in the SIMD tests. > - Eliminate a redundant F32x4 parameter for FP SIMD vector checking. We will only have this one FP type. > > LOG=N > BUG=v8:4124 > > Review-Url: https://codereview.chromium.org/2594043002 > Cr-Commit-Position: refs/heads/master@{#42154} > Committed: https://chromium.googlesource.com/v8/v8/+/5560bbb498252334595a39bb5f313ac8eb82cfe1 TBR=titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4124 Review-Url: https://codereview.chromium.org/2624713002 Cr-Commit-Position: refs/heads/master@{#42162} Committed: https://chromium.googlesource.com/v8/v8/+/0df234b0edb49fa83e8b7b5464d3340f8ac27fd9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -39 lines) Patch
M test/cctest/cctest.status View 1 chunk +4 lines, -0 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-simd.cc View 6 chunks +36 lines, -39 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
bbudge
Created Revert of [WASM] Fix failing Wasm SIMD F32x4 tests.
3 years, 11 months ago (2017-01-10 09:34:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2624713002/1
3 years, 11 months ago (2017-01-10 09:34:26 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 09:34:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/0df234b0edb49fa83e8b7b5464d3340f8ac...

Powered by Google App Engine
This is Rietveld 408576698