[WASM] Fix failing Wasm SIMD F32x4 tests.

[WASM] Fix failing Wasm SIMD F32x4 tests.
- Perform lane checks using FP compare instead of reinterpret casts. 0 and -0
will be different under I32 compare.
- Some arithmetic operations can generate NaN results, such as adding -Inf
and +Inf. Skip these tests until we have a way to do more sophisticated
FP comparisons in the SIMD tests.
- Eliminate a redundant F32x4 parameter for FP SIMD vector checking. We will only have this one FP type.

LOG=N
BUG=v8:6020
Review-Url: https://codereview.chromium.org/2594043002
Cr-Original-Commit-Position: refs/heads/master@{#42154}
Committed: https://chromium.googlesource.com/v8/v8/+/5560bbb498252334595a39bb5f313ac8eb82cfe1
Review-Url: https://codereview.chromium.org/2594043002
Cr-Commit-Position: refs/heads/master@{#43528}
Committed: https://chromium.googlesource.com/v8/v8/+/f3d26d3d552fb3408f0a94e415c3f4efc0a76dfb

[bbudge, 2016-12-21 19:06:56]

The CQ bit was checked by bbudge@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 19:07:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bbudge, 2016-12-21 19:09:10]

bbudge@chromium.org changed reviewers:
+ titzer@chromium.org

[bbudge, 2016-12-21 19:09:10]

My previous fix was sufficient for FP comparison. However, add, subtract and
other arithmetic ops may generate NaN resuls (e.g. -Inf + +Inf so we should
eliminate skip the test for those pairs.

[commit-bot: I haz the power, 2016-12-21 19:33:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 19:33:38]

Dry run: This issue passed the CQ dry run.

[bbudge, 2016-12-22 00:24:36]

The CQ bit was checked by bbudge@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 00:24:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bbudge, 2016-12-22 00:28:57]

The CQ bit was checked by bbudge@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 00:29:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bbudge, 2016-12-22 00:29:22]

Patchset #3 (id:40001) has been deleted

[bbudge, 2016-12-22 00:31:44]

Description was changed from

==========
[WASM] Skip SIMD arithmetic test values that generate NaN results.
Some arithmetic operations can generate NaN results, such as adding -Inf
and +Inf. Skip these tests until we have a way to do more sophisticated
FP comparisons in the SIMD tests.

LOG=N
BUG=v8:4124
==========

to

==========
[WASM] Fix failing Wasm SIMD F32x4 tests.
- Perform lane checks using FP compare instead of reinterpret casts. 0 and -0
will be different under I32 compare.
- Some arithmetic operations can generate NaN results, such as adding -Inf
and +Inf. Skip these tests until we have a way to do more sophisticated
FP comparisons in the SIMD tests.
- Eliminate a redundant F32x4 parameter for FP SIMD vector checking. We will
only have this one FP type.

LOG=N
BUG=v8:4124
==========

[bbudge, 2016-12-22 00:57:17]

The CQ bit was checked by bbudge@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 00:57:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 01:24:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 01:24:48]

Dry run: Try jobs failed on following builders:
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_arm_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng_trigger...)

[bbudge, 2016-12-22 01:42:42]

The CQ bit was checked by bbudge@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 01:42:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bbudge, 2016-12-22 01:43:30]

The CQ bit was checked by bbudge@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 01:43:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 02:07:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 02:07:39]

Dry run: This issue passed the CQ dry run.

[bbudge, 2016-12-22 17:35:55]

The CQ bit was checked by bbudge@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 17:36:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 17:59:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 17:59:55]

Dry run: This issue passed the CQ dry run.

[titzer, 2017-01-09 09:07:12]

lgtm

[bbudge, 2017-01-09 14:19:57]

The CQ bit was checked by bbudge@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 14:20:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 15:48:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 15:48:07]

Dry run: This issue passed the CQ dry run.

[bbudge, 2017-01-09 23:08:37]

The CQ bit was checked by bbudge@chromium.org

[bbudge, 2017-01-09 23:08:38]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/2594043002/#ps130001
(title: "Rebase.")

[commit-bot: I haz the power, 2017-01-09 23:08:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 23:11:18]

CQ is committing da patch.

Bot data: {"patchset_id": 130001, "attempt_start_ts": 1484003317616880,
"parent_rev": "ab14a1360104b815470cc06a5b600a057de6d5be", "commit_rev":
"5560bbb498252334595a39bb5f313ac8eb82cfe1"}

[commit-bot: I haz the power, 2017-01-09 23:11:23]

Description was changed from

==========
[WASM] Fix failing Wasm SIMD F32x4 tests.
- Perform lane checks using FP compare instead of reinterpret casts. 0 and -0
will be different under I32 compare.
- Some arithmetic operations can generate NaN results, such as adding -Inf
and +Inf. Skip these tests until we have a way to do more sophisticated
FP comparisons in the SIMD tests.
- Eliminate a redundant F32x4 parameter for FP SIMD vector checking. We will
only have this one FP type.

LOG=N
BUG=v8:4124
==========

to

==========
[WASM] Fix failing Wasm SIMD F32x4 tests.
- Perform lane checks using FP compare instead of reinterpret casts. 0 and -0
will be different under I32 compare.
- Some arithmetic operations can generate NaN results, such as adding -Inf
and +Inf. Skip these tests until we have a way to do more sophisticated
FP comparisons in the SIMD tests.
- Eliminate a redundant F32x4 parameter for FP SIMD vector checking. We will
only have this one FP type.

LOG=N
BUG=v8:4124

Review-Url: https://codereview.chromium.org/2594043002
Cr-Commit-Position: refs/heads/master@{#42154}
Committed:
https://chromium.googlesource.com/v8/v8/+/5560bbb498252334595a39bb5f313ac8eb8...
==========

[commit-bot: I haz the power, 2017-01-09 23:11:24]

Committed patchset #7 (id:130001) as
https://chromium.googlesource.com/v8/v8/+/5560bbb498252334595a39bb5f313ac8eb8...

[bbudge, 2017-01-10 09:34:24]

A revert of this CL (patchset #7 id:130001) has been created in
https://codereview.chromium.org/2624713002/ by bbudge@chromium.org.

The reason for reverting is: F32x4Add / Sub are still failing. I'll have to
investigate on ARM hardware when I get back..

[bbudge, 2017-02-28 16:38:15]

Description was changed from

==========
[WASM] Fix failing Wasm SIMD F32x4 tests.
- Perform lane checks using FP compare instead of reinterpret casts. 0 and -0
will be different under I32 compare.
- Some arithmetic operations can generate NaN results, such as adding -Inf
and +Inf. Skip these tests until we have a way to do more sophisticated
FP comparisons in the SIMD tests.
- Eliminate a redundant F32x4 parameter for FP SIMD vector checking. We will
only have this one FP type.

LOG=N
BUG=v8:4124

Review-Url: https://codereview.chromium.org/2594043002
Cr-Commit-Position: refs/heads/master@{#42154}
Committed:
https://chromium.googlesource.com/v8/v8/+/5560bbb498252334595a39bb5f313ac8eb8...
==========

to

==========
[WASM] Fix failing Wasm SIMD F32x4 tests.
- Perform lane checks using FP compare instead of reinterpret casts. 0 and -0
will be different under I32 compare.
- Some arithmetic operations can generate NaN results, such as adding -Inf
and +Inf. Skip these tests until we have a way to do more sophisticated
FP comparisons in the SIMD tests.
- Eliminate a redundant F32x4 parameter for FP SIMD vector checking. We will
only have this one FP type.

LOG=N
BUG=v8:4124

Review-Url: https://codereview.chromium.org/2594043002
Cr-Commit-Position: refs/heads/master@{#42154}
Committed:
https://chromium.googlesource.com/v8/v8/+/5560bbb498252334595a39bb5f313ac8eb8...
==========

[bbudge, 2017-02-28 23:31:34]

The CQ bit was checked by bbudge@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 23:31:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 23:56:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 23:56:02]

Dry run: Try jobs failed on following builders:
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/23470)
  v8_win_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng_triggered/bui...)

[bbudge, 2017-03-01 00:25:20]

Description was changed from

==========
[WASM] Fix failing Wasm SIMD F32x4 tests.
- Perform lane checks using FP compare instead of reinterpret casts. 0 and -0
will be different under I32 compare.
- Some arithmetic operations can generate NaN results, such as adding -Inf
and +Inf. Skip these tests until we have a way to do more sophisticated
FP comparisons in the SIMD tests.
- Eliminate a redundant F32x4 parameter for FP SIMD vector checking. We will
only have this one FP type.

LOG=N
BUG=v8:4124

Review-Url: https://codereview.chromium.org/2594043002
Cr-Commit-Position: refs/heads/master@{#42154}
Committed:
https://chromium.googlesource.com/v8/v8/+/5560bbb498252334595a39bb5f313ac8eb8...
==========

to

==========
[WASM] Fix failing Wasm SIMD F32x4 tests.
- Perform lane checks using FP compare instead of reinterpret casts. 0 and -0
will be different under I32 compare.
- Some arithmetic operations can generate NaN results, such as adding -Inf
and +Inf. Skip these tests until we have a way to do more sophisticated
FP comparisons in the SIMD tests.
- Eliminate a redundant F32x4 parameter for FP SIMD vector checking. We will
only have this one FP type.

LOG=N
BUG=v8:6020

Review-Url: https://codereview.chromium.org/2594043002
Cr-Commit-Position: refs/heads/master@{#42154}
Committed:
https://chromium.googlesource.com/v8/v8/+/5560bbb498252334595a39bb5f313ac8eb8...
==========

[bbudge, 2017-03-01 00:48:56]

The CQ bit was checked by bbudge@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 00:49:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bbudge, 2017-03-01 00:59:50]

bbudge@chromium.org changed reviewers:
+ bradnelson@chromium.org
- titzer@chromium.org

[bbudge, 2017-03-01 00:59:51]

+Brad, -Ben

This should get SIMD FP tests green on ARM hardware. It skips testing NaN
inputs, and tests where the expected result is a NaN or a very small magnitude
number.

[bbudge, 2017-03-01 01:15:03]

On 2017/03/01 00:59:51, bbudge wrote:
> +Brad, -Ben
> 
> This should get SIMD FP tests green on ARM hardware. It skips testing NaN
> inputs, and tests where the expected result is a NaN or a very small magnitude
> number.

Actually, what the heck, Ben, you can review too.

[bbudge, 2017-03-01 03:09:25]

The CQ bit was checked by bbudge@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 03:09:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 03:33:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 03:33:45]

Dry run: This issue passed the CQ dry run.

[bbudge, 2017-03-01 22:02:03]

The CQ bit was checked by bbudge@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 22:02:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 22:03:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 22:03:31]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/21841)
  v8_linux64_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_verify_csa_rel_n...)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/35788)

[bbudge, 2017-03-01 22:07:44]

The CQ bit was checked by bbudge@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 22:07:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 22:26:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 22:26:42]

Dry run: Try jobs failed on following builders:
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_nodcheck_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng_tr...)

[bbudge, 2017-03-01 22:38:19]

The CQ bit was checked by bbudge@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 22:38:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 23:03:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 23:03:35]

Dry run: This issue passed the CQ dry run.

[bbudge, 2017-03-01 23:04:51]

I'm going ahead and landing this, as a lot of FP stuff will soon be landing.

[bbudge, 2017-03-01 23:05:02]

The CQ bit was checked by bbudge@chromium.org

[bbudge, 2017-03-01 23:05:03]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/2594043002/#ps290001
(title: "Fix bad merge.")

[commit-bot: I haz the power, 2017-03-01 23:05:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bbudge, 2017-03-01 23:06:08]

The CQ bit was unchecked by bbudge@chromium.org

[bbudge, 2017-03-01 23:07:59]

The CQ bit was checked by bbudge@chromium.org

[bbudge, 2017-03-01 23:08:00]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/2594043002/#ps310001
(title: "Re-enable F32x4 tests.")

[commit-bot: I haz the power, 2017-03-01 23:08:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aseemgarg, 2017-03-01 23:13:32]

aseemgarg@chromium.org changed reviewers:
+ aseemgarg@chromium.org

[aseemgarg, 2017-03-01 23:13:33]

lgtm

[commit-bot: I haz the power, 2017-03-01 23:31:48]

CQ is committing da patch.

Bot data: {"patchset_id": 310001, "attempt_start_ts": 1488409679959420,
"parent_rev": "16bbc2fa43d99c1b39df6ade39a7e3bea3f26660", "commit_rev":
"f3d26d3d552fb3408f0a94e415c3f4efc0a76dfb"}

[commit-bot: I haz the power, 2017-03-01 23:31:54]

Description was changed from

==========
[WASM] Fix failing Wasm SIMD F32x4 tests.
- Perform lane checks using FP compare instead of reinterpret casts. 0 and -0
will be different under I32 compare.
- Some arithmetic operations can generate NaN results, such as adding -Inf
and +Inf. Skip these tests until we have a way to do more sophisticated
FP comparisons in the SIMD tests.
- Eliminate a redundant F32x4 parameter for FP SIMD vector checking. We will
only have this one FP type.

LOG=N
BUG=v8:6020

Review-Url: https://codereview.chromium.org/2594043002
Cr-Commit-Position: refs/heads/master@{#42154}
Committed:
https://chromium.googlesource.com/v8/v8/+/5560bbb498252334595a39bb5f313ac8eb8...
==========

to

==========
[WASM] Fix failing Wasm SIMD F32x4 tests.
- Perform lane checks using FP compare instead of reinterpret casts. 0 and -0
will be different under I32 compare.
- Some arithmetic operations can generate NaN results, such as adding -Inf
and +Inf. Skip these tests until we have a way to do more sophisticated
FP comparisons in the SIMD tests.
- Eliminate a redundant F32x4 parameter for FP SIMD vector checking. We will
only have this one FP type.

LOG=N
BUG=v8:6020

Review-Url: https://codereview.chromium.org/2594043002
Cr-Original-Commit-Position: refs/heads/master@{#42154}
Committed:
https://chromium.googlesource.com/v8/v8/+/5560bbb498252334595a39bb5f313ac8eb8...
Review-Url: https://codereview.chromium.org/2594043002
Cr-Commit-Position: refs/heads/master@{#43528}
Committed:
https://chromium.googlesource.com/v8/v8/+/f3d26d3d552fb3408f0a94e415c3f4efc0a...
==========

[commit-bot: I haz the power, 2017-03-01 23:31:55]

Committed patchset #16 (id:310001) as
https://chromium.googlesource.com/v8/v8/+/f3d26d3d552fb3408f0a94e415c3f4efc0a...

[Michael Achenbach, 2017-03-07 07:58:46]

FYI: This fails on arm chromebooks:
https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm/builds/2324