Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2624653002: iOS: Add the Page Info password/credit card string for HTTP pages. (Closed)

Created:
3 years, 11 months ago by lgarron
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews, emilyschechter, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

iOS: Add the Page Info password/credit card string for HTTP pages. This also: - Updates the "What do these mean?" link to "Learn more" to match Desktop material design. - Adds back the section icons for HTTP pages, which were actually supposed to be there all along.(crbug/640478). - Makes lgarron@ and estark@ owners of components/pageinfo_strings.grdp so we don't have to keep asking jochen@. BUG=656843, 640478

Patch Set 1 #

Patch Set 2 : iOS: Add the Material Page Info/HTTP bad password/credit card string for HTTP pages. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M components/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M components/pageinfo_strings.grdp View 2 chunks +4 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/omnibox/page_info_model.cc View 3 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (7 generated)
lgarron
jochen@, could you review the `components` change (2 files)? rohitrao@, could you review the iOS ...
3 years, 11 months ago (2017-01-10 00:56:54 UTC) #4
lgarron
On 2017/01/10 at 00:56:54, lgarron wrote: > jochen@, could you review the `components` change (2 ...
3 years, 11 months ago (2017-01-10 00:58:59 UTC) #7
lgarron
3 years, 11 months ago (2017-01-10 01:56:19 UTC) #9
Actually, ignore this. I'm going to refactor it significantly to play nicer with
other platforms.

Powered by Google App Engine
This is Rietveld 408576698