Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: ios/chrome/browser/ui/omnibox/page_info_model.cc

Issue 2624653002: iOS: Add the Page Info password/credit card string for HTTP pages. (Closed)
Patch Set: iOS: Add the Material Page Info/HTTP bad password/credit card string for HTTP pages. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/pageinfo_strings.grdp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/omnibox/page_info_model.cc
diff --git a/ios/chrome/browser/ui/omnibox/page_info_model.cc b/ios/chrome/browser/ui/omnibox/page_info_model.cc
index 5967c3c789d61ba714f8d805d2d090f8eba87319..b1aaf668c27f663064aedfae4834fbad52cb0d4a 100644
--- a/ios/chrome/browser/ui/omnibox/page_info_model.cc
+++ b/ios/chrome/browser/ui/omnibox/page_info_model.cc
@@ -147,7 +147,7 @@ PageInfoModel::PageInfoModel(ios::ChromeBrowserState* browser_state,
description.assign(l10n_util::GetStringUTF16(
IDS_PAGE_INFO_SECURITY_TAB_INSECURE_IDENTITY));
icon_id = ssl.security_style == web::SECURITY_STYLE_UNAUTHENTICATED
- ? ICON_NONE
+ ? ICON_STATE_INFO
: ICON_STATE_ERROR;
const base::string16 bullet = base::UTF8ToUTF16("\n • ");
@@ -175,9 +175,7 @@ PageInfoModel::PageInfoModel(ios::ChromeBrowserState* browser_state,
description.clear();
if (!ssl.certificate) {
// Not HTTPS.
- icon_id = ssl.security_style == web::SECURITY_STYLE_UNAUTHENTICATED
- ? ICON_NONE
- : ICON_STATE_ERROR;
+ icon_id = ICON_STATE_INFO;
description.assign(l10n_util::GetStringFUTF16(
IDS_PAGE_INFO_SECURITY_TAB_NOT_ENCRYPTED_CONNECTION_TEXT,
subject_name));
@@ -188,7 +186,7 @@ PageInfoModel::PageInfoModel(ios::ChromeBrowserState* browser_state,
// because ciphersuite is unknown. On iOS9 WKWebView blocks active
// mixed content, so warning should be about page look, not about page
// behavior.
- icon_id = ICON_NONE;
+ icon_id = ICON_STATE_INFO;
description.assign(l10n_util::GetStringUTF16(
IDS_PAGE_INFO_SECURITY_TAB_ENCRYPTED_INSECURE_CONTENT_WARNING));
} else {
« no previous file with comments | « components/pageinfo_strings.grdp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698